Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hub][ui] add regex validation for Identifier in forms #6089

Open
Tracked by #5582
RogerHYang opened this issue Jan 16, 2025 · 2 comments
Open
Tracked by #5582

[hub][ui] add regex validation for Identifier in forms #6089

RogerHYang opened this issue Jan 16, 2025 · 2 comments
Assignees
@RogerHYang
Labels
c/ui

Comments

@RogerHYang
Copy link
Contributor 

          Nice! We can add the same regex as validation in our forms too so that you don't have to make a round-trip to validate. can be done as a follow-up

Originally posted by @mikeldking in #6087 (review)
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Jan 16, 2025
@RogerHYang RogerHYang self-assigned this Jan 16, 2025
@RogerHYang RogerHYang mentioned this issue Jan 16, 2025
Open
@RogerHYang RogerHYang changed the title [prompts][ui] add regex validation for Identifier in forms [ui][hub] add regex validation for Identifier in forms Jan 16, 2025
@RogerHYang RogerHYang changed the title [ui][hub] add regex validation for Identifier in forms [hub][ui] add regex validation for Identifier in forms Jan 16, 2025
@dosubot dosubot bot added the c/ui label Jan 16, 2025
@mikeldking
Copy link
Contributor

Ooof, I hit this one bad right now 😢 - I think we should also allow underscores.

@RogerHYang RogerHYang moved this from 📘 Todo to 👨‍💻 In progress in phoenix Jan 27, 2025
@axiomofjoy
Copy link
Contributor

axiomofjoy commented Jan 27, 2025 •
edited
Loading

The default name when you try to clone a prompt includes a space and parentheses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RogerHYang RogerHYang

Labels
c/ui
Projects
phoenix
Status: 👨‍💻 In progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikeldking @axiomofjoy @RogerHYang