refactor: home stat pricing #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explorer.ark.io into refactor/home-stat-pricing
alexbarnsley
requested review from
faustbrian,
ItsANameToo and
samharperpittam
as code owners
|
@alexbarnsley how to test |
|
@ItsANameToo excellent question. Add the below to
There is still a size issue when using crypto - I believe this is handled in another task isn't it? |
ItsANameToo
requested changes
May 28, 2021
There was a problem hiding this comment.
@alexbarnsley can you make it switch immediately after the currency changes? Right now you have to wait until the statistics refresh before it picks up on the new currency
|
:sweating: |
|
Should be done @ItsANameToo |
ItsANameToo
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/kh8v3x
Checklist