fix: add shadow to the search module as per design #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsobries
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
samharperpittam
as code owners
9 tasks
|
@alfonsobries It sounds good, even compared to Figma! 👍🏽 |
|
@alfonsobries I'm going to mark as draft until the the UI dep is updated. I'd have updated it but I have a PR that also updates that dependency so figured I'd just wait |
…o fix/advanced-search-shadow
|
Just updated the ui dependency should be ready now |
ItsANameToo
requested changes
Jun 15, 2021
| @@ -8,7 +8,7 @@ | |||
| @search-type-changed.window="searchType = $event.detail" | |||
| class="w-full" | |||
| > | |||
| <div class="flex flex-col bg-white rounded-xl dark:bg-theme-secondary-900"> | |||
| <div class="flex flex-col bg-white rounded-lg md:shadow-lg-smooth dark:bg-theme-secondary-900"> | |||
There was a problem hiding this comment.
shouldn't this be rounded-xl? afaik we don't use rounded-lg much/at all
There was a problem hiding this comment.
@ItsANameToo the design uses less roundiness:
Current implementation (with xl)
With lg roundiness
Design
There was a problem hiding this comment.
@ItsANameToo so according to Oleg lg is correct
There was a problem hiding this comment.
@alfonsobries according to oleg it should be 12px, so xl 
I have updated it on your PR
ItsANameToo
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/mb5pj7
Adds the shadow used on the design, depends on https://github.com/ArkEcosystem/laravel-ui/pull/500/files
Checklist