Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle navbar dark mode on border and shadow #848

Merged
merged 3 commits into from
Jun 16, 2021
Merged

fix: handle navbar dark mode on border and shadow #848

merged 3 commits into from
Jun 16, 2021

Conversation

alfonsobries
Copy link
Member

@alfonsobries alfonsobries commented Jun 16, 2021 •
edited
Loading

Summary

https://app.clickup.com/t/mkcymq

Depends on: ArkEcosystemArchive/laravel-ui#512

Uses a new parameter on the UI library to toggle the dark mode on the navbar.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alfonsobries alfonsobries mentioned this pull request Jun 16, 2021
Merged
9 tasks
@alfonsobries alfonsobries marked this pull request as draft June 16, 2021 15:07
@ItsANameToo ItsANameToo marked this pull request as ready for review June 16, 2021 15:32
@ItsANameToo ItsANameToo merged commit a525419 into develop Jun 16, 2021
@ItsANameToo ItsANameToo deleted the fix/handle-dark-mode-on-navbar branch June 16, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

@faustbrian faustbrian Awaiting requested review from faustbrian

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfonsobries @ItsANameToo