Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile search advanced hidden #863

Merged
merged 6 commits into from
Jun 25, 2021
Merged

Conversation

alexbarnsley
Copy link
Member

Summary

https://app.clickup.com/t/mx85jh

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley
Copy link
Member Author

@ItsANameToo @samharperpittam could you have a look at this please when you get a chance. I've changed it so there's no bottom padding/spacing on devices < 768. This might nee to be approved as it strays from the design

@ItsANameToo
Copy link
Member

@alexbarnsley you don't really notice that lack of padding, but results in the button not being pushed up as soon as before :oleglala:

@alexbarnsley alexbarnsley marked this pull request as ready for review June 24, 2021 11:41
@leMaur leMaur self-assigned this Jun 25, 2021
@leMaur
Copy link
Contributor

leMaur commented Jun 25, 2021

@alexbarnsley It seems good to me!

image

@ItsANameToo ItsANameToo merged commit dbb3e3f into develop Jun 25, 2021
@ItsANameToo ItsANameToo deleted the fix/mobile-search-advancedg branch June 25, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants