Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hint module is now shown as Advanced Hint #294

Merged
merged 3 commits into from
Apr 16, 2018
Merged

Hint module is now shown as Advanced Hint #294

merged 3 commits into from
Apr 16, 2018

Conversation

CreepPork
Copy link
Member

When merged this pull request will:

  • Add the vanilla Hint module back in but with a changed name

@CreepPork CreepPork added change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. labels Apr 15, 2018
@CreepPork CreepPork added this to the 1.1.0 milestone Apr 15, 2018
@CreepPork CreepPork self-assigned this Apr 15, 2018
@CreepPork CreepPork requested a review from Kexanone April 15, 2018 20:00
Kexanone
Kexanone requested changes Apr 16, 2018
View reviewed changes
Copy link
Member

@Kexanone Kexanone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need an extra category for just one module.
Move it to somewhere else (e.g. curator).

Kexanone
Kexanone approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@Kexanone Kexanone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now.

@Kexanone Kexanone merged commit 3e1b648 into master Apr 16, 2018
@Kexanone Kexanone deleted the hintTweaks branch April 16, 2018 18:02
@Kexanone Kexanone modified the milestones: 1.1.0, 1.0.3 Jun 15, 2018
Kexanone pushed a commit that referenced this pull request Jul 6, 2018
@CreepPork @Kexanone
Updated release branch (#334)
d297718 
* Update readme paths

* update links in readme (part 2)

* Readme: Get rid of Heroku webhooks.

* Update README.md

* Small fixes (#293)

* Remove duplicate IDC

* Missing localization

* Remote control module still used vanilla function

* Rename stringtable key for delta distribution

* Hint module is now shown as Advanced Hint (#294)

* Hint module is now shown as Advanced Hint

* Swapped the category

* Add fr/de translations

* Reorganize and fix Adv Hint (#308)

* use ace_common_fnc_setName (#305)

* Fix for the Damage Building Module (#304)

* Use remoteExecCall instead of broadcasting the entire function

* Specify the target

* Fix undefined var error if ace is not installed. (#311)

* Added DeliciousJaffa (#317)

* Replace nonsensical default value (#320)

* Revised CAS modules (#319)

* Fix targeting and fire flares

* Address review comments + additional launch CM params

* Fix launch CM

* extraordinary important optimization

* Add change log for 1.0.3

* Small features (#321)

* Add artillery precision option

* Add artillery precision option (resolves #133)

* Revise paradrop: Drops below 150 => HALO (resolves #112)

* Add spaces for readability

* Correct change log (#322)

* Reorganize Tools (#323)

* move priv key folder to Achilles and ignore it

* Reorganize Tools

* New mintty-tmux session launcher

* Revised AddonBuilder batch script

* AchillesConnectToServer

* Update gitignore

* Rename Tools folder and add bat extension to AchillesAddonBuilder

* Fix travis tools path

* Reintroduce the faction filter (#326)

* Reintroduce the faction filter

* Update changlog.md

* Fix filter by uncommenting the required parts

* HALO (#324)

* Fix backpack inventory duplication

* Improve paradrop accuracy

* Add HALO option for reinforcements

* Improved the fitted function for HALO

* Fix error in function for HALO parameter

* More frequent checking time for height, since 1 sec can make a lot of difference in height

* Achilles_fnc_chute: Add default value for delay and reset chute deploy height to 100m

* Reinforcement: Set aircraft to carless, restrict HALO for planes only

* Add HALO option to teleport module

* Address point in review

* Address points in review (part 2)

* update change log

* Reinforcment: Fix CUP planes

* Achilles_fnc_chute: change chute deployment height to 120m

* Update changelog.md

* Use proper syntax for link in changlog

* Remove the extra space in the changelog

* Change 1.0.3 to 1.1.0 (#327)

* Fix locality issue for HALO option in the teleport module (#328)

* Broadcast chute function and exec on local machine

* Code optimization
@CreepPork CreepPork mentioned this pull request Aug 3, 2018
Merged
Kexanone pushed a commit that referenced this pull request Aug 3, 2018
@CreepPork @Kexanone
Updated release branch (#334) (#349)
641fc94 
* Update readme paths

* update links in readme (part 2)

* Readme: Get rid of Heroku webhooks.

* Update README.md

* Small fixes (#293)

* Remove duplicate IDC

* Missing localization

* Remote control module still used vanilla function

* Rename stringtable key for delta distribution

* Hint module is now shown as Advanced Hint (#294)

* Hint module is now shown as Advanced Hint

* Swapped the category

* Add fr/de translations

* Reorganize and fix Adv Hint (#308)

* use ace_common_fnc_setName (#305)

* Fix for the Damage Building Module (#304)

* Use remoteExecCall instead of broadcasting the entire function

* Specify the target

* Fix undefined var error if ace is not installed. (#311)

* Added DeliciousJaffa (#317)

* Replace nonsensical default value (#320)

* Revised CAS modules (#319)

* Fix targeting and fire flares

* Address review comments + additional launch CM params

* Fix launch CM

* extraordinary important optimization

* Add change log for 1.0.3

* Small features (#321)

* Add artillery precision option

* Add artillery precision option (resolves #133)

* Revise paradrop: Drops below 150 => HALO (resolves #112)

* Add spaces for readability

* Correct change log (#322)

* Reorganize Tools (#323)

* move priv key folder to Achilles and ignore it

* Reorganize Tools

* New mintty-tmux session launcher

* Revised AddonBuilder batch script

* AchillesConnectToServer

* Update gitignore

* Rename Tools folder and add bat extension to AchillesAddonBuilder

* Fix travis tools path

* Reintroduce the faction filter (#326)

* Reintroduce the faction filter

* Update changlog.md

* Fix filter by uncommenting the required parts

* HALO (#324)

* Fix backpack inventory duplication

* Improve paradrop accuracy

* Add HALO option for reinforcements

* Improved the fitted function for HALO

* Fix error in function for HALO parameter

* More frequent checking time for height, since 1 sec can make a lot of difference in height

* Achilles_fnc_chute: Add default value for delay and reset chute deploy height to 100m

* Reinforcement: Set aircraft to carless, restrict HALO for planes only

* Add HALO option to teleport module

* Address point in review

* Address points in review (part 2)

* update change log

* Reinforcment: Fix CUP planes

* Achilles_fnc_chute: change chute deployment height to 120m

* Update changelog.md

* Use proper syntax for link in changlog

* Remove the extra space in the changelog

* Change 1.0.3 to 1.1.0 (#327)

* Fix locality issue for HALO option in the teleport module (#328)

* Broadcast chute function and exec on local machine

* Code optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kexanone Kexanone Kexanone approved these changes

Assignees

@CreepPork CreepPork

Labels
change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@CreepPork @Kexanone