Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the Name Attribute Working for ACE3 #305

Merged
merged 1 commit into from
May 13, 2018
Merged

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented May 8, 2018

When merged this pull request will:

@Kexanone Kexanone added fix PR that is a fixes a bug. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. labels May 8, 2018
@Kexanone Kexanone added this to the 1.1.0 milestone May 8, 2018
@Kexanone Kexanone self-assigned this May 8, 2018
@Kexanone Kexanone requested a review from CreepPork May 8, 2018 21:47
@Kexanone Kexanone changed the title use ace_common_fnc_setName Get the Name Attribute Working for ACE3 May 8, 2018
@Kexanone Kexanone added the 3rd party mod Issue or PR that involves 3rd party mods. label May 8, 2018
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ace_common_fnc_setName actually JIP compatable?

@Kexanone
Copy link
Member Author

Yes, it is. The function sets a global variable.

@Kexanone Kexanone merged commit b577088 into master May 13, 2018
@Kexanone Kexanone deleted the FixAceNameAttribute branch May 13, 2018 06:26
@Kexanone Kexanone modified the milestones: 1.1.0, 1.0.3 Jun 15, 2018
Kexanone pushed a commit that referenced this pull request Jul 6, 2018
* Update readme paths

* update links in readme (part 2)

* Readme: Get rid of Heroku webhooks.

* Update README.md

* Small fixes (#293)

* Remove duplicate IDC

* Missing localization

* Remote control module still used vanilla function

* Rename stringtable key for delta distribution

* Hint module is now shown as Advanced Hint (#294)

* Hint module is now shown as Advanced Hint

* Swapped the category

* Add fr/de translations

* Reorganize and fix Adv Hint (#308)

* use ace_common_fnc_setName (#305)

* Fix for the Damage Building Module (#304)

* Use remoteExecCall instead of broadcasting the entire function

* Specify the target

* Fix undefined var error if ace is not installed. (#311)

* Added DeliciousJaffa (#317)

* Replace nonsensical default value (#320)

* Revised CAS modules (#319)

* Fix targeting and fire flares

* Address review comments + additional launch CM params

* Fix launch CM

* extraordinary important optimization

* Add change log for 1.0.3

* Small features (#321)

* Add artillery precision option

* Add artillery precision option (resolves #133)

* Revise paradrop: Drops below 150 => HALO (resolves #112)

* Add spaces for readability

* Correct change log (#322)

* Reorganize Tools (#323)

* move priv key folder to Achilles and ignore it

* Reorganize Tools

* New mintty-tmux session launcher

* Revised AddonBuilder batch script

* AchillesConnectToServer

* Update gitignore

* Rename Tools folder and add bat extension to AchillesAddonBuilder

* Fix travis tools path

* Reintroduce the faction filter (#326)

* Reintroduce the faction filter

* Update changlog.md

* Fix filter by uncommenting the required parts

* HALO (#324)

* Fix backpack inventory duplication

* Improve paradrop accuracy

* Add HALO option for reinforcements

* Improved the fitted function for HALO

* Fix error in function for HALO parameter

* More frequent checking time for height, since 1 sec can make a lot of difference in height

* Achilles_fnc_chute: Add default value for delay and reset chute deploy height to 100m

* Reinforcement: Set aircraft to carless, restrict HALO for planes only

* Add HALO option to teleport module

* Address point in review

* Address points in review (part 2)

* update change log

* Reinforcment: Fix CUP planes

* Achilles_fnc_chute: change chute deployment height to 120m

* Update changelog.md

* Use proper syntax for link in changlog

* Remove the extra space in the changelog

* Change 1.0.3 to 1.1.0 (#327)

* Fix locality issue for HALO option in the teleport module (#328)

* Broadcast chute function and exec on local machine

* Code optimization
Kexanone pushed a commit that referenced this pull request Aug 3, 2018
* Update readme paths

* update links in readme (part 2)

* Readme: Get rid of Heroku webhooks.

* Update README.md

* Small fixes (#293)

* Remove duplicate IDC

* Missing localization

* Remote control module still used vanilla function

* Rename stringtable key for delta distribution

* Hint module is now shown as Advanced Hint (#294)

* Hint module is now shown as Advanced Hint

* Swapped the category

* Add fr/de translations

* Reorganize and fix Adv Hint (#308)

* use ace_common_fnc_setName (#305)

* Fix for the Damage Building Module (#304)

* Use remoteExecCall instead of broadcasting the entire function

* Specify the target

* Fix undefined var error if ace is not installed. (#311)

* Added DeliciousJaffa (#317)

* Replace nonsensical default value (#320)

* Revised CAS modules (#319)

* Fix targeting and fire flares

* Address review comments + additional launch CM params

* Fix launch CM

* extraordinary important optimization

* Add change log for 1.0.3

* Small features (#321)

* Add artillery precision option

* Add artillery precision option (resolves #133)

* Revise paradrop: Drops below 150 => HALO (resolves #112)

* Add spaces for readability

* Correct change log (#322)

* Reorganize Tools (#323)

* move priv key folder to Achilles and ignore it

* Reorganize Tools

* New mintty-tmux session launcher

* Revised AddonBuilder batch script

* AchillesConnectToServer

* Update gitignore

* Rename Tools folder and add bat extension to AchillesAddonBuilder

* Fix travis tools path

* Reintroduce the faction filter (#326)

* Reintroduce the faction filter

* Update changlog.md

* Fix filter by uncommenting the required parts

* HALO (#324)

* Fix backpack inventory duplication

* Improve paradrop accuracy

* Add HALO option for reinforcements

* Improved the fitted function for HALO

* Fix error in function for HALO parameter

* More frequent checking time for height, since 1 sec can make a lot of difference in height

* Achilles_fnc_chute: Add default value for delay and reset chute deploy height to 100m

* Reinforcement: Set aircraft to carless, restrict HALO for planes only

* Add HALO option to teleport module

* Address point in review

* Address points in review (part 2)

* update change log

* Reinforcment: Fix CUP planes

* Achilles_fnc_chute: change chute deployment height to 120m

* Update changelog.md

* Use proper syntax for link in changlog

* Remove the extra space in the changelog

* Change 1.0.3 to 1.1.0 (#327)

* Fix locality issue for HALO option in the teleport module (#328)

* Broadcast chute function and exec on local machine

* Code optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party mod Issue or PR that involves 3rd party mods. fix PR that is a fixes a bug. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants