Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize Tools #323

Merged
merged 8 commits into from
Jun 19, 2018
Merged

Reorganize Tools #323

merged 8 commits into from
Jun 19, 2018

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Jun 17, 2018 •
edited
Loading

When merged this pull request will:

  • Reorganize the folder structure for tools
  • Update gitignore
  • Revise AddonBuilder.bat
  • Replace git-bash.bat with mintty.bat
  • Add AchillesConnectToServer.bat
  • Remove the obsolete markdown_changeLog_to_steam files (we no longer need them).

@Kexanone Kexanone added change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. labels Jun 17, 2018
@Kexanone Kexanone self-assigned this Jun 17, 2018
@Kexanone Kexanone requested a review from CreepPork June 17, 2018 17:58
CreepPork
CreepPork requested changes Jun 17, 2018
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addon Builder has no .bat extension

@CreepPork
Copy link
Member

Why did you remove the markdown for changelog script?

CreepPork
CreepPork requested changes Jun 17, 2018
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Tools is sentence case then all subdirectories should be too.

@Kexanone
Copy link
Member Author

  1. Thx, it somehow got lost.
  2. I no longer post change logs in steam, but post the link to GitHub. The change logs were a mess in Steam before.
  3. Actually you reminded me that I'm annoyed by the sentence case in Tools.

@CreepPork CreepPork merged commit 2f974cf into master Jun 19, 2018
@CreepPork CreepPork deleted the gitignore branch June 19, 2018 12:08
Kexanone pushed a commit that referenced this pull request Jul 6, 2018
@CreepPork @Kexanone
Updated release branch (#334)
d297718 
* Update readme paths

* update links in readme (part 2)

* Readme: Get rid of Heroku webhooks.

* Update README.md

* Small fixes (#293)

* Remove duplicate IDC

* Missing localization

* Remote control module still used vanilla function

* Rename stringtable key for delta distribution

* Hint module is now shown as Advanced Hint (#294)

* Hint module is now shown as Advanced Hint

* Swapped the category

* Add fr/de translations

* Reorganize and fix Adv Hint (#308)

* use ace_common_fnc_setName (#305)

* Fix for the Damage Building Module (#304)

* Use remoteExecCall instead of broadcasting the entire function

* Specify the target

* Fix undefined var error if ace is not installed. (#311)

* Added DeliciousJaffa (#317)

* Replace nonsensical default value (#320)

* Revised CAS modules (#319)

* Fix targeting and fire flares

* Address review comments + additional launch CM params

* Fix launch CM

* extraordinary important optimization

* Add change log for 1.0.3

* Small features (#321)

* Add artillery precision option

* Add artillery precision option (resolves #133)

* Revise paradrop: Drops below 150 => HALO (resolves #112)

* Add spaces for readability

* Correct change log (#322)

* Reorganize Tools (#323)

* move priv key folder to Achilles and ignore it

* Reorganize Tools

* New mintty-tmux session launcher

* Revised AddonBuilder batch script

* AchillesConnectToServer

* Update gitignore

* Rename Tools folder and add bat extension to AchillesAddonBuilder

* Fix travis tools path

* Reintroduce the faction filter (#326)

* Reintroduce the faction filter

* Update changlog.md

* Fix filter by uncommenting the required parts

* HALO (#324)

* Fix backpack inventory duplication

* Improve paradrop accuracy

* Add HALO option for reinforcements

* Improved the fitted function for HALO

* Fix error in function for HALO parameter

* More frequent checking time for height, since 1 sec can make a lot of difference in height

* Achilles_fnc_chute: Add default value for delay and reset chute deploy height to 100m

* Reinforcement: Set aircraft to carless, restrict HALO for planes only

* Add HALO option to teleport module

* Address point in review

* Address points in review (part 2)

* update change log

* Reinforcment: Fix CUP planes

* Achilles_fnc_chute: change chute deployment height to 120m

* Update changelog.md

* Use proper syntax for link in changlog

* Remove the extra space in the changelog

* Change 1.0.3 to 1.1.0 (#327)

* Fix locality issue for HALO option in the teleport module (#328)

* Broadcast chute function and exec on local machine

* Code optimization
@CreepPork CreepPork mentioned this pull request Aug 3, 2018
Merged
Kexanone pushed a commit that referenced this pull request Aug 3, 2018
@CreepPork @Kexanone
Updated release branch (#334) (#349)
641fc94 
* Update readme paths

* update links in readme (part 2)

* Readme: Get rid of Heroku webhooks.

* Update README.md

* Small fixes (#293)

* Remove duplicate IDC

* Missing localization

* Remote control module still used vanilla function

* Rename stringtable key for delta distribution

* Hint module is now shown as Advanced Hint (#294)

* Hint module is now shown as Advanced Hint

* Swapped the category

* Add fr/de translations

* Reorganize and fix Adv Hint (#308)

* use ace_common_fnc_setName (#305)

* Fix for the Damage Building Module (#304)

* Use remoteExecCall instead of broadcasting the entire function

* Specify the target

* Fix undefined var error if ace is not installed. (#311)

* Added DeliciousJaffa (#317)

* Replace nonsensical default value (#320)

* Revised CAS modules (#319)

* Fix targeting and fire flares

* Address review comments + additional launch CM params

* Fix launch CM

* extraordinary important optimization

* Add change log for 1.0.3

* Small features (#321)

* Add artillery precision option

* Add artillery precision option (resolves #133)

* Revise paradrop: Drops below 150 => HALO (resolves #112)

* Add spaces for readability

* Correct change log (#322)

* Reorganize Tools (#323)

* move priv key folder to Achilles and ignore it

* Reorganize Tools

* New mintty-tmux session launcher

* Revised AddonBuilder batch script

* AchillesConnectToServer

* Update gitignore

* Rename Tools folder and add bat extension to AchillesAddonBuilder

* Fix travis tools path

* Reintroduce the faction filter (#326)

* Reintroduce the faction filter

* Update changlog.md

* Fix filter by uncommenting the required parts

* HALO (#324)

* Fix backpack inventory duplication

* Improve paradrop accuracy

* Add HALO option for reinforcements

* Improved the fitted function for HALO

* Fix error in function for HALO parameter

* More frequent checking time for height, since 1 sec can make a lot of difference in height

* Achilles_fnc_chute: Add default value for delay and reset chute deploy height to 100m

* Reinforcement: Set aircraft to carless, restrict HALO for planes only

* Add HALO option to teleport module

* Address point in review

* Address points in review (part 2)

* update change log

* Reinforcment: Fix CUP planes

* Achilles_fnc_chute: change chute deployment height to 120m

* Update changelog.md

* Use proper syntax for link in changlog

* Remove the extra space in the changelog

* Change 1.0.3 to 1.1.0 (#327)

* Fix locality issue for HALO option in the teleport module (#328)

* Broadcast chute function and exec on local machine

* Code optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

Assignees

@Kexanone Kexanone

Labels
change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kexanone @CreepPork