HALO #324

Kexanone · 2018-06-17T22:22:43Z

When merged this pull request will:

Fix backpack inventory duplicate in Achilles_fnc_chute.
Improve the timing and chute deploy height for Achilles_fnc_chute.
Improve the accuracy of paradrops based on fitted functions.
Set aircrafts to careless created by the reinforcement module (makes armed aircrafts mor reliable).
Add HALO option to the reinforcement module.
Add HALO option to the teleport player module (resolves Paradrop Module #90).

… difference in height

CreepPork

What about ACE reserve parachute?

…y height to 100m

CreepPork · 2018-06-18T21:58:50Z

@AresModAchillesExpansion/addons/functions_f_achilles/scripts/fn_wpParadrop.sqf

 [_vehsGroup,_wp_pos,_radius] spawn
 {
+	params ["_vehsGroup", "_wp_pos", "_radius"];


CreepPork · 2018-06-18T22:00:07Z

...illesExpansion/addons/ui_f/functions/dialogs/fn_RscDisplayAttributes_CreateReinforcement.sqf

-				_ctrl ctrlEnable false;
-				_ctrl ctrlCommit 0;
+				private _ctrl_wpType = _dialog displayCtrl _x;
+				_ctrl_wpType ctrlSetFade 0.8;


CreepPork · 2018-06-18T22:00:42Z

@AresModAchillesExpansion/addons/functions_f_achilles/scripts/fn_wpParadrop.sqf

+private _crew = crew _firstVeh;
+private _passengerCount = {(assignedVehicleRole _x) select 0 == "CARGO"} count _crew;
+_radius = _radius + _passengerCount/2 * _speed/3.6;
+// account for speed displacement


CreepPork · 2018-06-18T22:01:47Z

@AresModAchillesExpansion/addons/functions_f_ares/features/fn_TeleportPlayers.sqf

@@ -1,4 +1,4 @@
-params[["_playersToTeleport", [objNull]], ["_teleportLocation", [0,0,0]], ["_showTeleportMessage", true], ["_includeVehicles", true]];
+params[["_playersToTeleport", [objNull]], ["_teleportLocation", [0,0,0]], ["_showTeleportMessage", true], ["_additionalOption", 0]];


Make it into multiple lines so it can be read

CreepPork · 2018-06-18T22:02:08Z

...lesExpansion/addons/modules_f_ares/Reinforcements/functions/fn_ReinforcementsCreateUnits.sqf

+if (_vehicle isKindOf "Air" and (_lzdz_type > 0)) then
+{
+	_vehicleUnloadWp setWaypointType "SCRIPTED";
+	private _script = ["\achilles\functions_f_achilles\scripts\fn_wpParadrop.sqf", "\achilles\functions_f_achilles\scripts\fn_wpFastrope.sqf"] select (_lzdz_type isEqualTo 1);


Multiple lines

CreepPork · 2018-06-19T12:07:38Z

@AresModAchillesExpansion/changelog.md

 	- Fix: Chute openning animation is smoother. #321
-	- Change: Paradroopers won't open their chute immediately at high altitude (>150 m) => HALO. #321
+	- Feature: AI accounts to a certain extend for paradrop displacment according to https://gyazo.com/32afcfefef24ba2cdc36eaa4c0467147 .


Why don't you make it as the markdown URL tags? Adding a dot at the end when you have a link is not good.

* Update readme paths * update links in readme (part 2) * Readme: Get rid of Heroku webhooks. * Update README.md * Small fixes (#293) * Remove duplicate IDC * Missing localization * Remote control module still used vanilla function * Rename stringtable key for delta distribution * Hint module is now shown as Advanced Hint (#294) * Hint module is now shown as Advanced Hint * Swapped the category * Add fr/de translations * Reorganize and fix Adv Hint (#308) * use ace_common_fnc_setName (#305) * Fix for the Damage Building Module (#304) * Use remoteExecCall instead of broadcasting the entire function * Specify the target * Fix undefined var error if ace is not installed. (#311) * Added DeliciousJaffa (#317) * Replace nonsensical default value (#320) * Revised CAS modules (#319) * Fix targeting and fire flares * Address review comments + additional launch CM params * Fix launch CM * extraordinary important optimization * Add change log for 1.0.3 * Small features (#321) * Add artillery precision option * Add artillery precision option (resolves #133) * Revise paradrop: Drops below 150 => HALO (resolves #112) * Add spaces for readability * Correct change log (#322) * Reorganize Tools (#323) * move priv key folder to Achilles and ignore it * Reorganize Tools * New mintty-tmux session launcher * Revised AddonBuilder batch script * AchillesConnectToServer * Update gitignore * Rename Tools folder and add bat extension to AchillesAddonBuilder * Fix travis tools path * Reintroduce the faction filter (#326) * Reintroduce the faction filter * Update changlog.md * Fix filter by uncommenting the required parts * HALO (#324) * Fix backpack inventory duplication * Improve paradrop accuracy * Add HALO option for reinforcements * Improved the fitted function for HALO * Fix error in function for HALO parameter * More frequent checking time for height, since 1 sec can make a lot of difference in height * Achilles_fnc_chute: Add default value for delay and reset chute deploy height to 100m * Reinforcement: Set aircraft to carless, restrict HALO for planes only * Add HALO option to teleport module * Address point in review * Address points in review (part 2) * update change log * Reinforcment: Fix CUP planes * Achilles_fnc_chute: change chute deployment height to 120m * Update changelog.md * Use proper syntax for link in changlog * Remove the extra space in the changelog * Change 1.0.3 to 1.1.0 (#327) * Fix locality issue for HALO option in the teleport module (#328) * Broadcast chute function and exec on local machine * Code optimization

Kexanone added 6 commits June 17, 2018 02:53

Fix backpack inventory duplication

60764be

Improve paradrop accuracy

d0309f2

Add HALO option for reinforcements

d2910d3

Improved the fitted function for HALO

a2b6559

Fix error in function for HALO parameter

fc56fd9

More frequent checking time for height, since 1 sec can make a lot of…

e9e1566

… difference in height

Kexanone added feature PR that adds a new feature to Achilles. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. labels Jun 17, 2018

Kexanone added this to the 1.0.3 milestone Jun 17, 2018

Kexanone self-assigned this Jun 17, 2018

Kexanone requested a review from CreepPork June 17, 2018 22:22

CreepPork reviewed Jun 18, 2018

View reviewed changes

Kexanone changed the title ~~Halo~~ HALO Jun 18, 2018

Kexanone added 3 commits June 18, 2018 23:18

Achilles_fnc_chute: Add default value for delay and reset chute deplo…

21d9365

…y height to 100m

Reinforcement: Set aircraft to carless, restrict HALO for planes only

9679e05

Add HALO option to teleport module

b322950

CreepPork requested changes Jun 18, 2018

View reviewed changes

Kexanone added 6 commits June 19, 2018 00:12

Address point in review

65d1111

Address points in review (part 2)

2514583

update change log

8ff61bb

Reinforcment: Fix CUP planes

07fb08c

Achilles_fnc_chute: change chute deployment height to 120m

9ad691d

Update changelog.md

d4cafda

CreepPork approved these changes Jun 19, 2018

View reviewed changes

CreepPork requested changes Jun 19, 2018

View reviewed changes

Use proper syntax for link in changlog

7afbeeb

CreepPork previously approved these changes Jun 19, 2018

View reviewed changes

Merge branch 'master' into HALO

1283c03

Kexanone dismissed CreepPork’s stale review via 1283c03 June 19, 2018 20:52

Remove the extra space in the changelog

67168aa

CreepPork approved these changes Jun 19, 2018

View reviewed changes

Kexanone merged commit 21f6577 into master Jun 20, 2018

Kexanone deleted the HALO branch June 20, 2018 00:10

CreepPork mentioned this pull request Aug 3, 2018

Updated release branch (#334) #349

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HALO #324

HALO #324

Kexanone commented Jun 17, 2018 •

edited

Loading

CreepPork left a comment

CreepPork Jun 18, 2018

CreepPork Jun 18, 2018

CreepPork Jun 18, 2018

CreepPork Jun 18, 2018

CreepPork Jun 18, 2018

CreepPork Jun 19, 2018

		@@ -1,4 +1,4 @@
		params[["_playersToTeleport", [objNull]], ["_teleportLocation", [0,0,0]], ["_showTeleportMessage", true], ["_includeVehicles", true]];
		params[["_playersToTeleport", [objNull]], ["_teleportLocation", [0,0,0]], ["_showTeleportMessage", true], ["_additionalOption", 0]];

HALO #324

HALO #324

Conversation

Kexanone commented Jun 17, 2018 • edited Loading

CreepPork left a comment

Choose a reason for hiding this comment

CreepPork Jun 18, 2018

Choose a reason for hiding this comment

CreepPork Jun 18, 2018

Choose a reason for hiding this comment

CreepPork Jun 18, 2018

Choose a reason for hiding this comment

CreepPork Jun 18, 2018

Choose a reason for hiding this comment

CreepPork Jun 18, 2018

Choose a reason for hiding this comment

CreepPork Jun 19, 2018

Choose a reason for hiding this comment

Kexanone commented Jun 17, 2018 •

edited

Loading