Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle VLS #365

Merged
merged 4 commits into from
Sep 22, 2018
Merged

Handle VLS #365

merged 4 commits into from
Sep 22, 2018

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Sep 17, 2018 •
edited
Loading

When merged this pull request will:

@Kexanone Kexanone added feature PR that adds a new feature to Achilles. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. labels Sep 17, 2018
@Kexanone Kexanone added this to the 1.2.0 milestone Sep 17, 2018
@Kexanone Kexanone self-assigned this Sep 17, 2018
@Kexanone Kexanone requested a review from CreepPork September 17, 2018 17:46
@Kexanone Kexanone modified the milestones: 1.3.0, 1.2.0 Sep 17, 2018
CreepPork
CreepPork requested changes Sep 17, 2018
View reviewed changes
...Expansion/addons/modules_f_ares/FireSupport/functions/fn_FireSupportArtilleryFireMission.sqf Outdated
private _missileMaxSpeed = getNumber (configfile >> "CfgAmmo" >> _missileClass >> "maxSpeed");
private _reloadTime = getNumber (configFile >> "cfgWeapons" >> _weaponClass >> "reloadTime");
private _magazineReloadTime = (1.3*getNumber (configfile >> "CfgWeapons" >> _weaponClass >> "magazineReloadTime"));
systemChat str [_reloadTime, _magazineReloadTime];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh-oh

CreepPork
CreepPork requested changes Sep 18, 2018
View reviewed changes
...Expansion/addons/modules_f_ares/FireSupport/functions/fn_FireSupportArtilleryFireMission.sqf Outdated
[_unit, [_target]] remoteExecCall ["fireAtTarget", _unit];
sleep _reloadTime;
};
sleep (1.3*_roundEta max 10);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3 * _roundEta max 10

...Expansion/addons/modules_f_ares/FireSupport/functions/fn_FireSupportArtilleryFireMission.sqf Outdated
{
_target attachTo [_selectedTarget, _deviation];
};
[side _unit, [_target, (1.3*_roundEta max 10) + _reloadTime*_rounds]] remoteExecCall ["reportRemoteTarget", _unit];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3 * _roundEta max 10

CreepPork
CreepPork requested changes Sep 21, 2018
View reviewed changes
...Expansion/addons/modules_f_ares/FireSupport/functions/fn_FireSupportArtilleryFireMission.sqf Outdated
private _artilleryAmmo = _battery select 2;

_artilleryAmmoDisplayName = (_battery select 2) apply {getText (configFile >> "CfgMagazines" >> _x >> "displayName")};
_battery params ["", "_units", "_artilleryAmmo"];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep it “_”

@Kexanone Kexanone merged commit 8922178 into master Sep 22, 2018
@Kexanone Kexanone deleted the vls branch September 22, 2018 19:01
CreepPork added a commit that referenced this pull request Dec 7, 2018
@CreepPork
Update to 1.2.0 (#415)
c77e5d1 
* Updated French Translations again (#355)

* Updated translations again.

* Another french translation update

* Added Switch Unit to ACE Zeus Interaction menu #298 (#361)

* Update Japanese translation (#363)

* Replace linalg and statistics utilities with CBA and BIS functions (#368)

* Use correct spawn position right from the beginning (#371)

* Fix exception handling and add support LWIRCM from RHS (#369)

* Fix exception handling and add support lwircm from RHS

* Use localization

* Handle VLS (#365)

* Handle VLS

* Remove loggers

* Address CreepPork's glorious review

* Use underscore for unused variable

* Added toggle include crew keybind (#362)

* Added toggle include crew keybind

* Improve description and add FR/DE localization

* fix grammar in FR translation

* Make Eden-like toggle

* Add Module Filter (#372)

* Prevent modules from being added automatically

* Prevent modules from being added automatically II

* Faction filter: Add side to text and sort the entries

* Add the available modules filter

* Remove workaround from Achilles init

* Reduce scheduled env to a minimum

* Apply module filter to module tree loading EH

* Fix undefined variable error in register custom modules

* Fix custom modules and duplicates for loaded missions

* Remove logger

* Surprise (#370)

* Add surprise

* Update credits

* Fix localization; Add destruction rate option

* Not for curators

* Remove changes to overcast

* Update comments; Remove unused function

* Prevent zero division error

* Use CamelCase

* Remove logger

* Address review

* Address 2nd review

* Remove unnecessary comment

* Extend Advanced CAS (#367)

* Add interpolation and angle/rotation functions

* update sqf_validator

* Implement plane CAS

* Offset radius correction

* Implement standard deviation

* Create a function for ownership changes

* Add new icons

* Add advanced CAS functions and update the module

* Improve exception handling

* Use BIS function

* Fix spacing in cfgFunctions

* Add examples

* Use joinString

* Use format instead of joinString

* Add semicolon at the end

* Use camelCase

* Update to 1.2.0 (#373)

* Update changlog and credits

* Update version

* Fix spelling

* Remove unused localization

* Fix spelling II

* Fix Nuke (#374)

* Handle the case where Zeus is the server

* Fix the nuke module duplicate

* Fixed typo #391 (#392)

* Revise GUI grids (#385)

* Increase maximum attribute window height

* Use pp for BI GUI grids; Move grid defs to separate file; Use dynamic H grids for inventory attribute

* Use grid defs from ui_f

* Use .inc instead of .h for SQF inclusions

* Include .inc in addon builder

* Fix Rsc Display Attributes

* Change .inc to .inc.sqf

* Fix order in data array (#387)

* Do not kill curators and logics (#384)

* Do not kill curators and logics

* Introduce _unitDies and handle Achilles revive in switchUnit functions

* Nuke now kills switched units as well

* Correct function name

* Do not kill 'invincible' units

* Revise Creation Tree Search Box (#407)

* Revise fix for loss of sides in creation tab

* Make use of CBA settings subcategories for faction/module filters

* Fix for FIA: Include side id in filter

* Port DZN search patch to Achilles

* Address review

* Extend comment

* Fixed "Error: unit has no smokes" on buildings (#393)

* Fixed wrong error message #382

* Address review

* Revise toggle include crew keybind (#396)

* Added feedback to player pressing toggle crew keybind #380

* Removed default keybind

* Small fixes for 1.2.0 RC (#408)

* Restore achilles modules when a player was promoted to Zeus

* Fix the issue that countermeasure keybinding is triggered when using the creation search field

* Add RHS AN/ALQ to CM

* CAS: Player exception; No empty parentheses; Exclude CMs & LDs

* Suppressive Fire: Exception handling for players

* Transfer ownership: Filter groups with players

* Fixed Armake complaints (#412)

* Missing semicolon

* Remove double semicolons; Add missing semicolons

* Replace double double quotes

* Replace more double double quotes

* Remove invalid syntax

* Update change log to 1.2.0 (#413)

* Merge RC change logs

* Fix spelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

Assignees

@Kexanone Kexanone

Labels
feature PR that adds a new feature to Achilles. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Add datalink & ace laser codes to laser designation module
2 participants
@Kexanone @CreepPork