Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added hotkey for chatter module #447

Merged
merged 4 commits into from
Jan 23, 2019
Merged

Added hotkey for chatter module #447

merged 4 commits into from
Jan 23, 2019

Conversation

CreepPork
Copy link
Member

@CreepPork CreepPork commented Jan 12, 2019 •
edited
Loading

When merged this pull request will:

@CreepPork CreepPork added feature PR that adds a new feature to Achilles. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. status/WIP PR that is a work-in-progress and should not be merged until the label is removed. testing/not working Indicates that the PR's latest commit has been tested but is not working as intended. labels Jan 12, 2019
@CreepPork CreepPork added this to the 1.3.0 milestone Jan 12, 2019
@CreepPork CreepPork self-assigned this Jan 12, 2019
@CreepPork CreepPork requested a review from Kexanone January 12, 2019 18:52
@CreepPork
Copy link
Member Author

CreepPork commented Jan 12, 2019 •
edited
Loading

Double press issue happens due to this error in CBA.
https://gyazo.com/193c2a28f00167a16a3c294108bf53d0

A very difficult issue to resolve as it seems to be only caused by the key bind line. If it's changed then on my machine it breaks. but on @oOKexOo's machine, it works.

@CreepPork CreepPork added the CBA fault Issue that is, in some way, caused by CBA A3. label Jan 12, 2019
@neilzar
Copy link
Collaborator

neilzar commented Jan 13, 2019

In my testing, I have not been able to reproduce the error message. I only figured out it is something to do with either of the function calls/spawns in there. And I think it might actually be spawning the chatter function.

@CreepPork
Copy link
Member Author

In it’s current state, no errors are shown. If chatter is called, not spawned, an error message is returned because ChooseDialog runs only in scheduled for some reason.

@CreepPork CreepPork added testing/tested Indicates that the PR's latest commit has been tested and is working properly. and removed CBA fault Issue that is, in some way, caused by CBA A3. status/WIP PR that is a work-in-progress and should not be merged until the label is removed. testing/not working Indicates that the PR's latest commit has been tested but is not working as intended. labels Jan 21, 2019
@CreepPork CreepPork requested a review from neilzar January 21, 2019 20:06
@Kexanone Kexanone merged commit aef5dc4 into master Jan 23, 2019
@Kexanone Kexanone deleted the hotkeyChatterModule branch January 23, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilzar neilzar neilzar approved these changes

@Kexanone Kexanone Awaiting requested review from Kexanone

Assignees

@CreepPork CreepPork

Labels
feature PR that adds a new feature to Achilles. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/tested Indicates that the PR's latest commit has been tested and is working properly.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CreepPork @neilzar @Kexanone