-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JWT authentication with Spring Security 3.2.2 #17
Conversation
…feat/spring-api
I forgot to mention, the already existing node.js API has not been deleted in this pull request. If you wish me to do it comment it below. |
Just performed a quick static review of the code, and I have some things I'd like you to consider:
That's about it. Other than that, I don't really see any other problem or question. Good job! Edit: add comment 4. |
Regarding 1 and 2, I have plans for adding unit testing and removing @Autowired annotations, although my objective for this pull request was to have a functional JWT authentication module and prove that we could use Java Spring Boot for the rest of our application. Maybe issues should be created for this tasks. When suggesting changes in the future try to use the Github comments on the specific lines so it is easier to find the problems with the code. (look at this link for reference) |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
For me this is good to merge as a start. |
An initial Spring Boot project has been created with Spring Initializr and the following features have been added:
The Spring Security configuration is not final and may be subject to changes in the future.
If there is any doubts about the implementation feel free to reach out or leave a comment in this pull request.