Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for the Authentication endpoints #62

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Conversation

Toto-hitori
Copy link
Contributor

I have added tests for the SpringBoot API testing the following endpoints:

  • /register
  • /login
  • /refresh-token

The tests developed from now on shall follow the same format as the ones provided here.
They shall also be added to a test suit in Github actions as described in #61

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@UO283615 UO283615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good job with the tests!

Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but neither Sonarcloud nor Github Actions seem to have actually run the tests. Could you add these tests to their configuration?

@Toto-hitori
Copy link
Contributor Author

Looks good, but neither Sonarcloud nor Github Actions seem to have actually run the tests. Could you add these tests to their configuration?

I have planned to end this by the end of the week although I wanted to have this merged before to finish all of the other tests in the rest of the branches. I will add the github actions in other branch (I also have to fix them either way)

@Toto-hitori Toto-hitori dismissed jjgancfer’s stale review March 1, 2024 13:50

Not to be added in this PR

@Toto-hitori Toto-hitori merged commit 619d2f8 into develop Mar 1, 2024
2 checks passed
@Toto-hitori Toto-hitori deleted the test/login branch March 5, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants