Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The work in @makiam's fork #7

Open
peteihis opened this issue May 11, 2019 · 4 comments
Open

The work in @makiam's fork #7

peteihis opened this issue May 11, 2019 · 4 comments

Comments

@peteihis
Copy link
Contributor

There seem to be a lot of commits in @makiam's branch that are not put into a PR yet. Emphasis on the technical side as it would seem. I hope we won't be doing too much of the same work over again but I'll try to focus on just getting it to work again...

@makiam
Copy link
Contributor

makiam commented May 11, 2019

... and more is not yet published. I started work to at least build project. And back to work Textures And Materials...

@peteihis
Copy link
Contributor Author

Don't you think you should split the work in to multiple pull requests?

What I'm going to do next to myself is just to get the xmls right enough and the code thorough the compiler before anything else.

@makiam
Copy link
Contributor

makiam commented May 11, 2019

I try to fix TaPDObjectMaterialDialog/TaPDObjectTextureDialog classes... Both of them depends of deleted classes MaterialsDialog/TexturesDialog and deleted scene showMaterials/showTextures methods. Currenntly in AOI we have ObjectTextureDialog which replaces this dialogs. But unfortunatly this dialog can be called only from main LayoutWindow as it passed as parameter to class constructor.
Seems we need to update this class too to avoid such dependency....

@peteihis
Copy link
Contributor Author

I thought I had answered already. It seems I forgot to press "Comment".

Anyway, the UI of what you posted to SF seems to be working, but this Textures and Materials seems like tricky bit to solve. I'm not sure but I thought I saw in the TaPD code some things that seemed like copies of, what is in the AoI code? I'm wondering if that is the way to go for the time being though, that would not be the ideal case. Making a change on the AoI-side and getting it released seems like a slow track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants