refactor(ui/stat): use class selector for pageview elements by default #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Modified statistics UI component. Default selectors for `pvEl` and `countEl` have changed from `#ArtalkPV` and `#ArtalkCount` to `.artalk-pv-count` and `.artalk-comment-count` (See #826).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 25.23% 25.30% +0.07%
==========================================
Files 196 196
Lines 8093 8093
==========================================
+ Hits 2042 2048 +6
+ Misses 5924 5920 -4
+ Partials 127 125 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Mister-Hope
approved these changes
May 22, 2024
|
I added backward compatible selector query this is no longer a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statistics UI component has been updated. The default selectors for
pvElandcountElhave changed from#ArtalkPVand#ArtalkCountto.artalk-pv-countand.artalk-comment-count(see #826 for more details). However, it remains backward compatible with the#ArtalkPVand#ArtalkCountelements for older versions, no HTML client updates are necessary.In this PR, we also introduced a configuration option called
statPageKeyAttr(value"data-page-key"by default) for customizing the attribute name that the statistics component uses to fetch the page key.fixes #826