Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn’t update automatically after changing REV variable #5

Open
bouk opened this issue Sep 13, 2018 · 1 comment
Open

Doesn’t update automatically after changing REV variable #5

bouk opened this issue Sep 13, 2018 · 1 comment

Comments

@bouk
Copy link

bouk commented Sep 13, 2018

Great job on the project! It works nicely.

There’s just one issue I’ve walked into: if you keep using the same location for the data and restart the container after changing the REV variable, the unit script won’t update the jar automatically. Instead you have to delete the server jar manually. It would be great if the init script compared the version of the jar, or did maybe put the version into the file name of the jar so it knew to install after changing the revision.

@mathuin
Copy link
Contributor

mathuin commented Sep 20, 2018

I have a modified version of spigot_init.sh which addresses this issue and a few others.

  • If REV is set to a particular version number, say '1.13', the script checks to see if spigot-1.13.jar exists -- if not, it is created.
  • If REV is unset, or is set to 'latest', the jar is rebuilt every time.

There are some other changes, too, like creating a non-root user and abstracting out the URLs to script variables. I can make a pull request if that's desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants