Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'URLRequestConvertible' is not a subtype of 'NSURLRequest' #66

Closed
delebedev opened this issue Nov 5, 2014 · 6 comments · Fixed by #69
Closed

'URLRequestConvertible' is not a subtype of 'NSURLRequest' #66

delebedev opened this issue Nov 5, 2014 · 6 comments · Fixed by #69

Comments

@delebedev
Copy link
Contributor

2014-11-05 14-48-36 moya swift edited

I've integrated Alamofire as subproject and dragg-n-dropped Moya sources as displayed at the screenshot and got this strange error.

Xcode 6.1

@delebedev
Copy link
Contributor Author

It can be fixed by changing signature of Custom closure:
case Custom((URLRequestConvertible, [String: AnyObject]?) -> (NSURLRequest, NSError?)) but I am really not sure that it's the right way.

@ashfurrow
Copy link
Member

Hmm. Is it possible that the version of Alamofire is newer than the submodule in this repo?

@delebedev
Copy link
Contributor Author

Absolutely sure it is because I've checked out the latest master of Alamofire separately.

@ashfurrow
Copy link
Member

OK, cool, well then it's on me to update our version. I'm pretty busy for the next day or so, so if you submitted a pull request, that would be welcome. Otherwise, I'll update it tomorrow.

@delebedev
Copy link
Contributor Author

If the fix I've described is suitable I'll make the PR (it can be fixed by using the same closure signature as in Alamofire)

@ashfurrow
Copy link
Member

That would be awesome! If you do, make a note of it in the changelog, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants