Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide total tokens staked through Token API #754

Open
bobo-k2 opened this issue Apr 24, 2023 · 3 comments
Open

Provide total tokens staked through Token API #754

bobo-k2 opened this issue Apr 24, 2023 · 3 comments
Labels
enhancement New feature or request has dependency Tier 1 Low complexity task UI DAO Community task

Comments

@bobo-k2
Copy link
Contributor

bobo-k2 commented Apr 24, 2023

Motivation
It would be very useful to have historical information about staked amounts on the portal dashboard page. This is the second ticket in series of tickets related to adding total staked ASTR/SDN on the dashboard page.
Depends on #753

Suggested Solution
Create a new endpoint /api/v1/:network/dapps-staking/staked/:period on [Token API service](https://github.com/AstarNetwork/astar-token-api). The endpoint should fetch tokens staked data from deployed indexer (see #753) GraphQL endpoint and provide results in form:

[timestamp, staked_value][]

Alternatives
Not at the moment. Any ideas are welcome.

Additional Information
Please comment if the ticket is not clear enough.

@bobo-k2 bobo-k2 added the enhancement New feature or request label Apr 24, 2023
@bobo-k2 bobo-k2 added Tier 1 Low complexity task UI DAO Community task labels Apr 26, 2023
@MarcoB95-lab
Copy link

MarcoB95-lab commented Apr 28, 2023

Hi , I have a question regarding the UI DAO Ambassador Task. I worked on task 754, where I cloned the repository and added a new endpoint to the URL (see screeenshot). However, I realized that the necessary data cannot be retrieved without an indexer, which means that task 753 needs to be completed first.

grafik

I am not familiar with working on an indexer, so I am unsure if I am capable of handling it. Should I complete task 753 before moving on to 754? Or is it possible to work on the 754 task, even if the API has not the necessary indexer in place?

@MarcoB95-lab
Copy link

MarcoB95-lab commented Apr 28, 2023

Another suggestion. Why leave a input field for a string for a api query which only has 2 possible parameters?
Would it not be better do it as a dropdown? Like that?

grafik

@Kahonnohak
Copy link
Contributor

Kahonnohak commented May 1, 2023

@MarcoB95-lab Please leave your PR here or in the relevant ticket so we can continue the logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request has dependency Tier 1 Low complexity task UI DAO Community task
Projects
None yet
Development

No branches or pull requests

3 participants