Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ansible): use public API for getting buffer lines #514

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Aug 9, 2023

📑 Description

vim.filetype.getlines is actually a private function (I did this originally so my b 😢). This moves it to the correct public API

ℹ Additional Information

@mehalter mehalter requested a review from a team August 9, 2023 19:29
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter mehalter merged commit 3cda952 into main Aug 9, 2023
@mehalter mehalter deleted the ansible_fix branch August 9, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants