Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(harpoon): change word terminal to term #725

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix(harpoon): change word terminal to term #725

merged 1 commit into from
Jan 17, 2024

Conversation

MrMic
Copy link
Contributor

@MrMic MrMic commented Jan 16, 2024

Closes #721

📑 Description

Changes made in init.lua file in harpoon plugin.

ℹ Additional Information

Copy link

github-actions bot commented Jan 16, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@luxus luxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luxus luxus merged commit 7351bf0 into AstroNvim:main Jan 17, 2024
13 checks passed
@luxus
Copy link
Member

luxus commented Jan 17, 2024

@MrMic are you using version 2? maybe you could create a PR for harpoon v2 branch? to close another issue
#685

@MrMic
Copy link
Contributor Author

MrMic commented Jan 17, 2024

@luxus Not using Harpoon v2 yet. Even if I saw it deprecated.
If I have time in the next few days or weeks, I will try to PR the v2 in the
repo if anyone does not do this beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harpoon terminal bug
2 participants