-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(neorg)!: fix breaking change in v8.0.0 #813
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
See #634. |
Changed target branch to v4. |
I'm running v3 of astronvim currently. If this is going to be postponed until after v4 is released, it might be worth it to pin neorg's version to its last commit before the recent changes ( |
Sure, sounds like a plan. I'll do that in v4 then. The v3 branch is frozen until then |
📑 Description
Neorg recently released version 8.0.0 with a breaking change that requires slightly changing the config. This PR applies the necessary changes to get the plugin working correctly again. This is a breaking change because it requires a couple new system dependencies: Lua 5.1/LuaJIT and the Lua header files.
ℹ Additional Information
Neorg now includes a
build.lua
file to handle the build process. The old build step specified withbuild
is no longer sufficient, so specifying it leads to a broken installation as it overrides the includedbuild.lua
script.Neorg now uses luarocks to manage its own dependencies, which is automatically compiled and installed by the
luarocks.nvim
plugin dependency using a system installation of Lua 5.1/LuaJIT with the Lua header files.