Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-useful tests #326

Open
spco opened this issue Aug 9, 2018 · 4 comments
Open

Un-useful tests #326

spco opened this issue Aug 9, 2018 · 4 comments
Labels
Milestone

Comments

@spco
Copy link
Collaborator

spco commented Aug 9, 2018

We already know that we can condense the existing tests down, or replace them with a better framework. This is just to note that the test short, short_end_of_day, and short_no_pre are all stationary models - the only non-zero concentrations they have are CH3OH and NO2, neither of which then appears in the accompaying .fac file. This isn't very useful.

@rs028
Copy link
Collaborator

rs028 commented Aug 10, 2018

If I recall correctly all the short* tests are basically just testing the various possible configuration of the environment variables and reading in the contraints.

@rs028
Copy link
Collaborator

rs028 commented Aug 15, 2018

Somewhat related question. Does each test need to have its own mcm/ folder? (solved by #357)

@rs028
Copy link
Collaborator

rs028 commented Jun 28, 2019

An INFO.md file with the list and a brief description of each behaviour tests should be added (only for those we keep, not those we plan to delete and/or replace with unit tests).

@rs028
Copy link
Collaborator

rs028 commented Mar 19, 2020

We also need a better way to log the results of the tests. At the moment one has to scroll up the terminal to see the results of the unit tests, for example, and this could be a pain if there are lots of tests. Maybe some of the output can be redirected to a log file (see also #320).

@rs028 rs028 added this to the version 1.x milestone May 15, 2020
@rs028 rs028 moved this to Testing and Numerical Issues in Roadmap Sep 22, 2022
@rs028 rs028 added this to Roadmap Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Testing and Numerical Issues
Development

No branches or pull requests

2 participants