Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cmd::Cmd instead of cmd::String in replay funciton #62

Closed
hyrodium opened this issue Apr 18, 2023 · 1 comment · Fixed by #74
Closed

Use cmd::Cmd instead of cmd::String in replay funciton #62

hyrodium opened this issue Apr 18, 2023 · 1 comment · Fixed by #74
Labels

Comments

@hyrodium
Copy link
Collaborator

The current implementation uses cmd="--color=yes" as a keyword argument, but it seems cmd::Cmd=`--color=yes` is better because we can remove split in this line.

julia> cmd = "--color=yes -q"
"--color=yes -q"

julia> `julia $(split(cmd))`
`julia --color=yes -q`

julia> cmd = `--color=yes -q`
`--color=yes -q`

julia> `julia $cmd`
`julia --color=yes -q`
@terasakisatoshi
Copy link
Member

This makes sense to me.

If this proposal is merged, I think it should be released as a v0.5 feature. This would be a destructive change for users who pass an object (type String) to the "cmd" argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants