Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to define custom session factory + types #2

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

danielroe
Copy link
Collaborator

Questions

  1. should onSuccess be fully optional (as in this implementation)?
  2. would we instead like to require onSuccess (e.g. for redirect) but also always use the defined session factory for setting user session?
  3. we should investigate type issues with @nuxt/ui-pro in playground (run pnpm test:types:playground to see them)

@danielroe danielroe requested a review from atinux November 7, 2023 15:26
@danielroe danielroe self-assigned this Nov 7, 2023
@atinux
Copy link
Owner

atinux commented Nov 7, 2023

should onSuccess be fully optional (as in this implementation)?

We should make it required as best practice and avoid doing hidden stuff

would we instead like to require onSuccess (e.g. for redirect) but also always use the defined session factory for setting user session?

Not sure to understand the defined session factory you mean

For UI Pro types, I think it comes from Nuxt 3.8.1, @benjamincanac is working on it

@danielroe
Copy link
Collaborator Author

so I guess the question is whether we just run the session handler in defineSession + automatically do setUserSession?

@atinux atinux merged commit 15764a7 into main Nov 7, 2023
3 checks passed
@atinux atinux deleted the feat/define-session branch November 7, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants