Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Quality filter contentTypes filtering problem #15

Closed
kylie-m opened this issue Jan 11, 2024 · 2 comments
Closed

Data Quality filter contentTypes filtering problem #15

kylie-m opened this issue Jan 11, 2024 · 2 comments
Assignees
Milestone

Comments

@kylie-m
Copy link

kylie-m commented Jan 11, 2024

In an all data query (https://biocache.ala.org.au/occurrences/search?q=) with the DQ filters on, there are an expected 1.1 million- ish records excluded based on record type (ie basis of record).

When you click on the filter to see the excluded records, the query doesn't return the 1.1 million-ish records, instead only 279 records, and this seems to be related to how the query is parsed. The FOSSIL_SPECIMEN make it in, but not the "Environmental DNA" contentType

https://biocache.ala.org.au/occurrence/search?q=&qualityProfile=ALA&disableAllQualityFilters=true&fq=basisOfRecord%3A%22FOSSIL_SPECIMEN%22+%28%2BbasisOfRecord%3AMATERIAL_SAMPLE+%2BcontentTypes%3AEnvironmental+DNA%29#tab_mapView

@adam-collins adam-collins self-assigned this Jan 18, 2024
@adam-collins
Copy link
Contributor

The moment we entered anything remotely complex into a filter value the chance that this would work was reduced. Given the very wide variety of inputs possible, this is the most robust solution:

  1. Added a field to QualityCategory for the inverseFilter. This permits overriding the value that is automatically generated and sometimes incorrect.
  2. Updated the UI to put in a warning when the inverseFilter may be required.

Image

In test, please test.

@kylie-m
Copy link
Author

kylie-m commented Jan 19, 2024

Thanks Adam!

@peggynewman I gave this a try on test and it's looking ok to me. Since you initially raised it, could you also give it a try and confirm you're happy with the changes?

@adam-collins adam-collins mentioned this issue Mar 27, 2024
@adam-collins adam-collins added this to the 2.0.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants