Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in BroadcasterConfig#getExecutorServer() javadoc #1640

Closed
dmitry-treskunov opened this issue Jun 24, 2014 · 4 comments
Closed

Error in BroadcasterConfig#getExecutorServer() javadoc #1640

dmitry-treskunov opened this issue Jun 24, 2014 · 4 comments

Comments

@dmitry-treskunov
Copy link
Contributor

It seems that there is an error in this javadoc:

By default it returns an {@link java.util.concurrent.Executors#newFixedThreadPool(int)} of size 1.

But actually by default this executor service is created using Executors.newCachedThreadPool
@dmitry-treskunov
Copy link
Contributor Author

The same for getAsyncWriteService()

@gdrouet
Copy link
Member

gdrouet commented Jun 24, 2014

Hi,

please send your doc refactoring in a PR and I'll merge it!

@dmitry-treskunov
Copy link
Contributor Author

#1641

@gdrouet
Copy link
Member

gdrouet commented Jun 24, 2014

Thanks

@gdrouet gdrouet closed this as completed Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gdrouet @dmitry-treskunov