AtmosphereResourceLifecycleInterceptor does not resume resource for long-polling

[janbols]

According to the javadoc, the AtmosphereResourceLifecycleInterceptor takes care of resuming resources.
However it only sets resumeOnBroadcast to true. That's it. Nothing more. The only place, I can see, this flag being checked is in the AbstractReflectorAtmosphereHandler.

However for all other AtmosphereHandlers, this will not resume a suspended event when long-polling is used and data is written to it.

On Atmosphere 1.0.0.RC1

[jfarcand]

@janbols, can you elaborate of the expected behavior? Thanks!

[janbols]

I would expect that, when using long-polling behavior, the AtmosphereResourceLifecycleInterceptor would take care of resuming and suspending as the javadoc shows. The only thing the custom AtmosphereHandler needs to do is write data if suspended like in the example below:

    public void onStateChange(AtmosphereResourceEvent event) throws IOException {
        if (event.isSuspended()) {
                event.getResource().getResponse().getWriter().write( event.getMessage().toString() );
        }
    }

However, when a message arrives, for long-polling, the AtmosphereResourceLifecycleInterceptor only sets a resumeOnBroadcast flag. It doesn't do resource.resume() or anything else. As a result resource.resume() is never called and no messages arrive.
Unless I'm doing something terribly wrong here.

[jfarcand]

OK, clarified the documentation . Applicaiton needs to take care of resuming in case they don't use Broadcaster. Thanks!!!

[janbols]

Ok, thanks. Is it generally advised to extend from AbstractReflectorAtmosphereHandler?

[jfarcand]

Yes as the logic can be quite complex...but not mandatory as everything can be done in an AtmosphereHandler as well. BTW take a look at the new OnMessage handler...that one is quite simple as well. Thanks for the feedback.