Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint on editor focus #77

Merged
merged 3 commits into from
Jun 1, 2014
Merged

Lint on editor focus #77

merged 3 commits into from
Jun 1, 2014

Conversation

rockymadden
Copy link

There is one item to note:

Currently when a file is opened for the first time, both the lintOnEditorFocus and lintOnSave features will fire at the same time. Thereafter, both work exactly as you would expect. There are a couple ways we could mitigate this issue, however I wanted to see if there was a preference on how to do so before coding it.

@rockymadden rockymadden changed the title Lint on editor focus feature Lint on editor focus Jun 1, 2014
@rockymadden
Copy link
Author

Oh, I forgot to include a use case:

It is often the case in Scala (and I imagine other languages) that I will make a change in file A that corrects an issue with file B. Assuming both were already open in Atom (very common for me), currently I have to trigger re-linting via another method (e.g. save or modify) when I go back to file B. It would be nice if when I simply switched my focus back to file B that it would re-lint itself.

@iam4x
Copy link
Contributor

iam4x commented Jun 1, 2014

@rockymadden Nice catch! The double execution is the source of the double message in the status bar issue! Great!

@iam4x
Copy link
Contributor

iam4x commented Jun 1, 2014

@rockymadden Look my new PR, #79 use @debouncedLint instead of @lint this will avoid the double lint execution ;)

And thank's again I couldn't find where the status bar double message bug was coming from. Two in one :D !

@iam4x iam4x added this to the 0.4.9 milestone Jun 1, 2014
@rockymadden
Copy link
Author

@iam4x perfect on the debouncedLint, thank you! I am going to tweak this PR to leverage.

@iam4x
Copy link
Contributor

iam4x commented Jun 1, 2014

🎉

iam4x pushed a commit that referenced this pull request Jun 1, 2014
@iam4x iam4x merged commit 46b7444 into steelbrain:master Jun 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants