Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Use setup file #8

Closed
knyghty opened this issue Sep 5, 2014 · 7 comments · Fixed by #17
Closed

Use setup file #8

knyghty opened this issue Sep 5, 2014 · 7 comments · Fixed by #17

Comments

@knyghty
Copy link

knyghty commented Sep 5, 2014

It would be nice if the linter could use a setup.cfg or tox.ini etc. if found in the root project directory.

Normally flake8 will read these automatically if there's one in the same directory as it is invoked from, but there is also a --config option to specify a path.

@zgoda
Copy link

zgoda commented Sep 11, 2014

That would be great. I could mute some annoying "issues" such as hard-coded line length.

@matthewwithanm
Copy link
Contributor

Based on what the jshint linter's doing, it seems like this would be a pretty small change, but I think the package settings would clobber anything in the config /:

@badray
Copy link
Contributor

badray commented Sep 25, 2014

@matthewwithanm Yes it would be pretty small change, just give me a few days, becouse I'm while quiting my job and founding my own company, so I don't much time right now.

@matthewwithanm
Copy link
Contributor

Didn't mean to rush you!

@boxy-robot
Copy link

There's also the home config to read at ~/config/flake8. Seems like flake8 would read it automatically but it doesn't seem to.

http://flake8.readthedocs.org/en/latest/config.html

@matthewwithanm
Copy link
Contributor

I can put together a PR for this; I'm just not sure of how to resolve the package settings. (Personally, I don't think there should be any package-level linter config and instead it should just rely on the normal flake8 configuration behavior.)

@matthewwithanm
Copy link
Contributor

@yellottyellott @AtomLinter is actually making a copy of the file in a tmp directory, which can mess up a bunch of stuff like this. I mentioned it in steelbrain/linter#213 but it seems unlikely to be changed. Unfortunately, that means individual linter packages have to reimplement this kind of logic 💩

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants