Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Lint error if code folded #97

Closed
phuihock opened this issue Oct 18, 2015 · 5 comments
Closed

Lint error if code folded #97

phuihock opened this issue Oct 18, 2015 · 5 comments
Labels

Comments

@phuihock
Copy link

Steps to reproduce:

  1. Fold one or more blocks
  2. Lint

You should see: TypeError: Cannot read property 'tokens' of undefined

Versions:
flake8: 2.4.1 (pep8: 1.5.7, mccabe: 0.3.1, pyflakes: 0.8.1) CPython 2.7.6 on Linux
atom: 1.0.9
OS: Ubuntu 14.04.3 LTS

@Arcanemagus
Copy link
Member

Your Atom version is very old, update that (and probably most of your packages...) and see if you are still seeing issues.

I'm not seeing this on the current version.

@phuihock
Copy link
Author

Upgraded atom to 1.0.19 and updated all packages but same error:
TypeError: Cannot read property 'tokens' of undefined
at extractRange (/home/phuihock/.atom/packages/linter-flake8/lib/main.coffee:59:7)
at /home/phuihock/.atom/packages/linter-flake8/lib/main.coffee:171:22

Versions:
flake8: same version
linter-flake8: 1.9.0
linter: 1.8.1

I tried linting folded .js files with linter-jshint, no issues. If you need more info, do let me know.

@Arcanemagus
Copy link
Member

Interesting, I couldn't reproduce this on one computer, but I now can on a different computer. Looking into the cause of this.

@Arcanemagus
Copy link
Member

A fix is pushed out in v1.9.1, let me know if you see any further issues!

@phuihock
Copy link
Author

Awesome. The fix works. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants