Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Adhere to foodcritic's default exclusions #47

Open
haidangwa opened this issue May 25, 2017 · 1 comment
Open

Adhere to foodcritic's default exclusions #47

haidangwa opened this issue May 25, 2017 · 1 comment

Comments

@haidangwa
Copy link

haidangwa commented May 25, 2017

I am getting warnings for foodcritic violation in the spec directory. As of Foodcritic/foodcritic#148 being resolved, the spec and test directories are ignored by foodcritic.

I am getting this in my *_spec.rb files under spec/unit/recipes.

image

Versions:

  • linter-foodcritic 0.5.4
  • Mac OS Sierra
$ chef exec gem list foodcritic

*** LOCAL GEMS ***

foodcritic (11.0.0, 10.4.1, 9.0.0, 8.2.0, 7.1.0, 7.0.1)
@tas50
Copy link

tas50 commented May 4, 2018

This is certainly something that should get fixed here. Foodcritic does a poor job of detecting what is a cookbook and what isn't and it often gets confused by specs and test cookbooks which should get tested. I'm working on fixing that in Foodcritic, but it requires a fundamental redesign to how it handles file detection so it might be a while.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants