Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

V2 linter API support #12

Merged
merged 27 commits into from
Feb 14, 2019
Merged

V2 linter API support #12

merged 27 commits into from
Feb 14, 2019

Conversation

vzamanillo
Copy link
Contributor

@vzamanillo vzamanillo commented Feb 13, 2019

Fixes #8
Fixes #10

Change the major version because move from CoffeScript to ES. Incorporates the changes to support the V2 linter API plus specs and support for slim deprecation warning messages.

Change the major version because move from CoffeScript to ES. Incorporates the changes to support the V2 linter API plus specs and support for slim deprecation warning messages.
Copy link
Member

@Arcanemagus Arcanemagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I see so far, a great start though!

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
spec/linter-slim-spec.js Outdated Show resolved Hide resolved
lib/linter-slim.js Outdated Show resolved Hide resolved
lib/linter-slim.js Outdated Show resolved Hide resolved
lib/linter-slim.js Show resolved Hide resolved
lib/linter-slim.js Outdated Show resolved Hide resolved
lib/linter-slim.js Outdated Show resolved Hide resolved
@Arcanemagus
Copy link
Member

Arcanemagus commented Feb 13, 2019

You should also commit the package-lock.json, as it will be managed by Renovate (and used in Atom).

@Arcanemagus Arcanemagus mentioned this pull request Feb 13, 2019
Copy link
Member

@Arcanemagus Arcanemagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things.

package.json Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@Arcanemagus
Copy link
Member

Enabled Travis CI, and turned on builds for forked PRs in Circle CI.

@Arcanemagus
Copy link
Member

Btw, if you install Docker on your machine you can test the CircleCI builds almost exactly by running:

docker run --rm -it arcanemagus/atom-docker-ci:latest bash

That will get you a shell in the container, you'll need to manually git clone the repo, but other than that it should be essentially identical to the environment CircleCI runs them in. Note that you can skip the "start VFB" step when manually testing as I have it configured to do that automatically for you.

@vzamanillo
Copy link
Contributor Author

Btw, if you install Docker on your machine you can test the CircleCI builds almost exactly by running:

docker run --rm -it arcanemagus/atom-docker-ci:latest bash

That will get you a shell in the container, you'll need to manually git clone the repo, but other than that it should be essentially identical to the environment CircleCI runs them in. Note that you can skip the "start VFB" step when manually testing as I have it configured to do that automatically for you.

Didn't know, thank you!

Copy link
Member

@Arcanemagus Arcanemagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vzamanillo vzamanillo merged commit 6f60ae8 into AtomLinter:master Feb 14, 2019
@vzamanillo vzamanillo deleted the v2-linter-api-support branch February 15, 2019 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants