You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
This portion of the parser did not allow webAO to work properly because it did not allow empty strings - note the use of self.ArgType.STR instead of self.ArgType.STR_OR_EMPTY.
A workaround has been already put into place for webAO (AttorneyOnline/webAO@b0b4e66), but it would be best to fix it on the server side.
The text was updated successfully, but these errors were encountered:
@stonedDiscord , sorry, I just saw this. I'll put the PR in again. I've got to stop making such humongous PR's and just have them do 1 thing rather than multiple things
* Delegate background, character and music reloading to helper functions
* Fail soon if loaded YAML was empty
* Areas with no longer valid backgrounds are forced to change to first entry
* Check background list is a list of str or str-like
* More strict checking of music lists
* Remove AO1 packet support
* Prompt players to rejoin the server if the character list changes
* Update changelog and bump up version number
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See this code:
tsuserver3/server/network/aoprotocol.py
Lines 414 to 415 in ec65799
This portion of the parser did not allow webAO to work properly because it did not allow empty strings - note the use of
self.ArgType.STR
instead ofself.ArgType.STR_OR_EMPTY
.A workaround has been already put into place for webAO (AttorneyOnline/webAO@b0b4e66), but it would be best to fix it on the server side.
The text was updated successfully, but these errors were encountered: