Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

2.8 IC packet extensions do not allow empty strings #107

Open
oldmud0 opened this issue Aug 1, 2020 · 3 comments
Open

2.8 IC packet extensions do not allow empty strings #107

oldmud0 opened this issue Aug 1, 2020 · 3 comments
Assignees
Labels

Comments

@oldmud0
Copy link
Member

oldmud0 commented Aug 1, 2020

See this code:

self.ArgType.INT, self.ArgType.STR, self.ArgType.STR, # screenshake, frames_shake, frames_realization
self.ArgType.STR, self.ArgType.INT, self.ArgType.STR, # frames_sfx, additive, effect

This portion of the parser did not allow webAO to work properly because it did not allow empty strings - note the use of self.ArgType.STR instead of self.ArgType.STR_OR_EMPTY.

A workaround has been already put into place for webAO (AttorneyOnline/webAO@b0b4e66), but it would be best to fix it on the server side.

@caleb-mabry
Copy link
Contributor

Created a PR to try and get feedback on a potential alternate solution instead of having to go through self.ArgType several different times.

@stonedDiscord
Copy link
Member

# frames_sfx, additive, effect

still there

@caleb-mabry
Copy link
Contributor

@stonedDiscord , sorry, I just saw this. I'll put the PR in again. I've got to stop making such humongous PR's and just have them do 1 thing rather than multiple things

Crystalwarrior referenced this issue in Crystalwarrior/KFO-Server Feb 11, 2022
* Delegate background, character and music reloading to helper functions

* Fail soon if loaded YAML was empty

* Areas with no longer valid backgrounds are forced to change to first entry

* Check background list is a list of str or str-like

* More strict checking of music lists

* Remove AO1 packet support

* Prompt players to rejoin the server if the character list changes

* Update changelog and bump up version number
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants