You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
However, once the song reaches play_music, the parameter becomes "loop", and then becomes "looping" in courtroom on the client, and again becomes "loop" in aomusicplayer
I understand looking for "length" in music.yaml, to keep compatibility with old music.yaml files that used that to indicated looping, but I believe it should look for a "loop" parameter first (and that should be the encouraged choice going forward), and be referred to as such in the code, to prevent confusion. (This also goes for making the naming in courtroom.cpp and aomusicplayer.cpp consistent for the client code).
The text was updated successfully, but these errors were encountered:
Currently, both aoprotocol and tsuserver refer to the parameter used to determine looping as "length" (and looks for "length" in music.yaml)
tsuserver3/server/network/aoprotocol.py
Line 729 in fefe5b0
tsuserver3/server/tsuserver.py
Line 349 in fefe5b0
However, once the song reaches play_music, the parameter becomes "loop", and then becomes "looping" in courtroom on the client, and again becomes "loop" in aomusicplayer
tsuserver3/server/area_manager.py
Line 313 in fefe5b0
I understand looking for "length" in music.yaml, to keep compatibility with old music.yaml files that used that to indicated looping, but I believe it should look for a "loop" parameter first (and that should be the encouraged choice going forward), and be referred to as such in the code, to prevent confusion. (This also goes for making the naming in courtroom.cpp and aomusicplayer.cpp consistent for the client code).
The text was updated successfully, but these errors were encountered: