Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noscript Warning on trainers page #51

Open
Auroratide opened this issue Jan 28, 2023 · 2 comments
Open

Noscript Warning on trainers page #51

Auroratide opened this issue Jan 28, 2023 · 2 comments
Labels
trainers the trainers section

Comments

@Auroratide
Copy link
Owner

Javascript is required since this is a static site trying to emulate dynamic routing.
@Auroratide Auroratide added the trainers the trainers section label Jan 28, 2023
@Auroratide
Copy link
Owner Author

A noscript tag is generally not enough. If the javascript fails to load or has some weird error, we need to show a message.

@Auroratide
Copy link
Owner Author

We also need to show a message if local storage is not supported, or the browser is in incognito mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
trainers the trainers section
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Auroratide