Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable annotation #196

Closed
ljacqu opened this issue Apr 19, 2021 · 1 comment
Closed

Nullable annotation #196

ljacqu opened this issue Apr 19, 2021 · 1 comment
Milestone
1.4.0 Release

Comments

@ljacqu
Copy link
Member

ljacqu commented Apr 19, 2021

Look if there's a better annotation or dependency to use to mark nullability:

  • Right now I'm pulling in Findbugs to be able to use @Nullable...
  • @Nullable is in the javax package which might violate an Oracle license (??? I think... I lost track of the whole discussion)
  • @CheckForNull is now a thing that Guava is changing to and apparently that was intended for usage and @Nullable is being misused by everyone... but then more tools seem to pick up on @Nullable than on @CheckForNull

Guava issue 2960 is a nice entry point into this nightmare. Seems like the checker framework (JSR 308) is the way to go?
See also Spotbugs issue 130
@ljacqu ljacqu added this to the 1.4.0 Release milestone Apr 19, 2021
@Sxtanna Sxtanna mentioned this issue Oct 16, 2021
Merged
@ljacqu
Copy link
Member Author

ljacqu commented Jun 4, 2022

Solved with PR #235 -> javax replaced with Jetbrains annotations everywhere

@ljacqu ljacqu closed this as completed Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
1.4.0 Release
Development

No branches or pull requests
1 participant
@ljacqu