Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Java 11 #347

Open
ljacqu opened this issue Aug 10, 2023 · 1 comment
Open

Switch to Java 11 #347

ljacqu opened this issue Aug 10, 2023 · 1 comment
Milestone

Comments

@ljacqu
Copy link
Member

ljacqu commented Aug 10, 2023

Not planning to switch soon, but to keep some improvements/adjustments that we could make after switching:

  • See comments in code referencing this issue
  • Use List.of and Set.of where appropriate instead of more verbose Arrays.asList, etc.
  • !Optional.isPresent = Optional.isEmpty
  • collect(toList()) -> Stream#toList
  • Upgrade to Mockito 5
  • Remove Mockito exclusion from dependabot.yml
@ljacqu ljacqu added this to the Backlog milestone Aug 21, 2023
@gamerover98
Copy link
Contributor

Hi, updating to Java 11 just to use these methods doesn't make much sense. Additionally, compatibility with Java 8 is more important in my opinion, as there are older projects that require the use of this JDK version.

However, if there is a way to create a second Jar file that is compatible with Java 8, as they do, for example, with HSQLDB, then you can proceed with the modification.

<dependency>
    <groupId>org.hsqldb</groupId>
    <artifactId>hsqldb</artifactId>
    <version>2.7.1</version>
    <classifier>jdk8</classifier>
    <type>jar</type>
</dependency>

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants