Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable theme switching while some process is running. #733

Closed
pohuing opened this issue Jun 4, 2023 · 6 comments · Fixed by #734
Closed

Add option to disable theme switching while some process is running. #733

pohuing opened this issue Jun 4, 2023 · 6 comments · Fixed by #734
Labels
enhancement New feature or request

Comments

@pohuing
Copy link
Contributor

pohuing commented Jun 4, 2023

Describe the enhancement or feature you'd like
Option to disable switching if certain programs are running.

Describe alternatives you've considered
The idle switch and the low GPU usage switches.

Additional context
The low GPU usage threshold does not work on my AMD GPU, because it's either too beefy, or the sampling is just broken(AMD reports null for sensors occasionally, so this isn't an issue with this application itself).
Furthermore, the GPU load threshold is inadequate for some scenarios:
I don't mind if my system switches while watching videos, or doing a render, or streaming per se. In those situations the frame drops are irrelevant, yet would be prevented by GPU usage.
On the other side, plenty of timing specific games use very little resources, such as League of Legends, Counter Strike, any roguelike really, similar for a lot of fighting games like Rivals of Aether.

@pohuing pohuing added the enhancement New feature or request label Jun 4, 2023
@Armin2208
Copy link
Member

Idea: don't switch while Game Mode is activated as an additional option for the "Don't switch while playing video games" setting.

@pohuing
Copy link
Contributor Author

pohuing commented Jun 5, 2023

I don't know anyone who uses Game Mode to be honest. Having a list of processes to block the switching sounds the most straight forward to me.
Also, I'm not aware of an API to actually check if it's active. The docs are pretty lackluster and the only somewhat related API I can find has been deprecated for years now.

@pohuing
Copy link
Contributor Author

pohuing commented Jun 5, 2023

I'll take a shot at implementing this myself. I'm not very familiar with WPF and C# anymore though.

@Armin2208
Copy link
Member

Every gamer uses Windows Game Mode, because it's enabled by default for every game. People need to opt out of Game Mode to have it disabled.

But you are right, listening if game mode is activate is not good documented. PowerToys uses a method in Always on Top.
grafik

Btw thanks for your pull request!

@Spiritreader
Copy link
Member

Spiritreader commented Jun 8, 2023

Your implementation is now available in the latest beta.

I've made a few small changes to the UI such that the combo box loads asynchronously and also removed debug messages that were being logged on every timer tick.

In my testing everything worked, thanks again!

@pohuing
Copy link
Contributor Author

pohuing commented Jun 8, 2023

Was fun working on this, thanks for the quick help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants