Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit-flow.php missing headers #550

Closed
paulschreiber opened this issue Nov 14, 2019 · 4 comments
Closed

edit-flow.php missing headers #550

paulschreiber opened this issue Nov 14, 2019 · 4 comments

Comments

@paulschreiber
Copy link

The file edit-flow.php is missing a header. This was deliberately removed in 7b8f449

Removing these headers breaks the plugin for VIP clients:

The plugin edit-flow/edit-flow.php has been deactivated due to an error: The plugin does not have a valid header.
@cojennin
Copy link
Contributor

Yea, we've got the same problem as Restricted Site Access.

The simplest fix is to load like wpcom_vip_load_plugin( 'edit-flow/edit_flow.php' );

Headers in both edit-flow.php and edit_flow.php won't work, we're just going to have this issue again

@paulschreiber
Copy link
Author

Release 1.0 with edit_flow.php removed. You can make a breaking change like that since you're bumping the major version number.

@cojennin
Copy link
Contributor

That's a thought, though it would end up deactivating Edit Flow on the upgrade. In the meantime wpcom_vip_load_plugin( 'edit-flow/edit_flow.php' ); should work for folks on VIP. Same thing folks on VIP do for Restricted Site Access

@cojennin
Copy link
Contributor

Closing for now, can revisit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants