Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new OptionsRaceConditionSniff #648

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

rebeccahum
Copy link
Contributor

Fixes #637.

Let the roasting begin, @jrfnl! 😄

@jrfnl
Copy link
Collaborator

jrfnl commented Apr 15, 2021

@rebeccahum Instead of roasting (and sorry, yes it would be a painful roasting), let's try something different.

Let's start with a little exercise:

  • Can you try to write out - in words, not code - the "code pattern" you are trying to look for ?
  • Then make a list of all the requirements which need to be met for the code pattern to be considered a match.
  • Next, look at the code you've written and try to find all the assumptions you've made in it to account for specific code samples instead of accounting for the pattern.

@GaryJones GaryJones added this to the 3.x milestone Aug 26, 2023
@rebeccahum rebeccahum modified the milestones: 3.0.1, 3.x May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sniff to delete_option() + add_option
3 participants