Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing UI for DFP Async #70

Open
rinatkhaziev opened this issue Apr 16, 2013 · 5 comments
Open

Confusing UI for DFP Async #70

rinatkhaziev opened this issue Apr 16, 2013 · 5 comments

Comments

@rinatkhaziev
Copy link
Contributor

http://cl.ly/image/0b3f2F152E14

Now take a look at this screenshot and honestly tell me if you know what to put into DFP ID, and Tag ID. I sure don't. I mean, I could figure it out, but average Joe will spend a lot of effort.

We should either provide help notices for each column or rename columns to be less confusing.

My suggestions are:

  • Tag -> (Tag|Ad) Dimensions
  • Tag ID -> Tag Target Element
  • DFP ID -> DFP User Id

Thoughts?

@natebot
Copy link

natebot commented Apr 16, 2013

I agree. I'll ask our ad managers what they would call the fields or get details about the labels used in the DFP dashboard they use. Using the same labels should help bridge the gap.

On Apr 15, 2013, at 9:44 PM, Rinat K notifications@github.com wrote:

http://cl.ly/image/0b3f2F152E14

Now take a look at this screenshot and honestly tell me if you know what to put into DFP ID, and Tag ID. I sure don't. I mean, I could figure it out, but average Joe will spend a lot of effort.

We should either provide help notices for each column or rename columns to be less confusing.

My suggestions are:

Tag -> (Tag|Ad) Dimensions
Tag ID -> Tag Target Element
DFP ID -> DFP User Id
Thoughts?

Reply to this email directly or view it on GitHub.

@NRG-R9T
Copy link
Contributor

NRG-R9T commented Apr 16, 2013

the fields of DFP dashboard have absolutely no relation to the code generated to implement. (Edit: besides, the network code is ready to look up in the dashboard, and the divId is not really needed from DFP Dashboard, cause it can be anything, right?)

the terminology of "Google DFP" in their help topics would help to configure "ad code manager".

so here it is:

Google Publisher Tag (often named GPT) is the therm to look for.

http://support.google.com/dfp_sb/bin/answer.py?hl=en&answer=2372721&topic=1651546&ctx=topic

DFP ID -> Network Code

you can find the network code for your account on the Admin tab under Network Settings

Tag ID -> divId

divId is the ID of the div element that will contain this ad slot, you can find it in the output of the "The Google Publisher Tag generator": defineSlot(unitName, size, divId)

Example of the Google Publisher Tag generator:

<script type='text/javascript'>
googletag.cmd.push(function() {
googletag.defineSlot('/130598692/Billboard', [960, 90], 'div-gpt-ad-XXXXXXXXXXXXX-0').addService(googletag.pubads());
googletag.defineSlot('/130598692/Fixed_Panel', [336, 700], 'div-gpt-ad-XXXXXXXXXXXXX-1').addService(googletag.pubads());
googletag.defineSlot('/130598692/Full_Banner', [468, 60], 'div-gpt-ad-XXXXXXXXXXXXX-2').addService(googletag.pubads());
googletag.defineSlot('/130598692/Leaderboard', [728, 90], 'div-gpt-ad-XXXXXXXXXXXXX-3').addService(googletag.pubads());
googletag.pubads().enableSingleRequest();
googletag.enableServices();
});
</script>

I guess the exact GPT divId doesn't matter, but it definitely helps to identicate, what to do and how Ad Code manager works to someone like me, someone thinking like average joe. ;)

@rinatkhaziev
Copy link
Contributor Author

Yep, makes total sense.

@NRG-R9T
Copy link
Contributor

NRG-R9T commented Apr 17, 2013

thanks. the rest:

Tag -> size

Tag Name - unit name ( Name of the Ad Unit in Inventory)

I found it there: https://support.google.com/dfp_sb/bin/answer.py?hl=en&answer=2372721&expand=googletag_details#defineSlot

defineSlot

googletag.defineSlot(unitName, sizes, divId)
Constructs an ad slot with a given ad unit name and size and associates it with the ID of a div element on the page that will contain the ad.

Parameters:
string unitName - Full path of the ad unit with the network code and unit name.
number sizes - Width and height of the ad unit within brackets and separated by a comma. You can specify more than one size using this syntax: [[width1, height1], [width2, height2]]
string divId - Publisher-specified ID for the div element containing the ad.

Returns:
adSlot - The newly created ad slot.

Example:
// Ad unit = "/networkCode/unitName"; sizes = [[width1, height1], [width2, height2]]
googletag.defineSlot("/1234567/leaderboard", [[468, 60], [728, 90]], "div-1");

@GaryJones
Copy link
Contributor

Seems related to #123.

@GaryJones GaryJones modified the milestones: 0.6, Future Release Mar 14, 2022
@GaryJones GaryJones removed this from the Future Release milestone Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants