Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classes to wrapping div to allow better styling #71

Open
nickdaugherty opened this issue Apr 16, 2013 · 0 comments
Open

Add classes to wrapping div to allow better styling #71

nickdaugherty opened this issue Apr 16, 2013 · 0 comments

Comments

@nickdaugherty
Copy link
Member

Would be beneficial to add some descriptive classes on an ad's wrapping div (rather than just a numeric id) for better control via CSS.

I think 'acm-wrapper' and the region name, such as 'acm-728x90_header' would be sufficient.

A good use case is centering ad regions - currently you must match the id which means if the user ever changes regions, the CSS will need to be redone.

@ghost ghost assigned nickdaugherty Apr 16, 2013
@GaryJones GaryJones modified the milestones: 0.4.1, 0.6, Future Release, 0.7.0 Mar 14, 2022
@GaryJones GaryJones modified the milestones: 0.7.0, Future Release Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants