Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad code tag still rendered if no valid ad codes found #72

Open
nickdaugherty opened this issue Apr 16, 2013 · 0 comments
Open

Ad code tag still rendered if no valid ad codes found #72

nickdaugherty opened this issue Apr 16, 2013 · 0 comments

Comments

@nickdaugherty
Copy link
Member

Ad region <div>s are still rendered even if there is no matching ad code to display in them. This causes some strange output because the <div> doesn't get a proper id or size applied. For example, this is the html produced if there is no matching ad for a region:

<div style="width:%width%px; height:%height%px;" id="%tag_id%">
    <script type="text/javascript">
        googletag.cmd.push(function() { googletag.display('%tag_id%'); });
    </script>
</div>

Would be best to skip the html entirely if no ad will be displayed.

@GaryJones GaryJones modified the milestones: 0.6, Future Release, 0.7.0 Mar 14, 2022
@GaryJones GaryJones modified the milestones: 0.7.0, Future Release Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants