Wrap registered widgets in callbacks to track widget validation errors #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
* Include core as a source in addition to plugins and themes. * Refactor source comments to only consist of JSON-encoded source data. * Include the function name in the source.
westonruter
force-pushed
the
add/widget-validation-reporting
branch
from
3d82d39
to
5033910
Compare
* Ensure that filters/actions added during execution of page get wrapped. * Prevent hook wrapping from happening on callbacks for functions with parameters passed by reference. * Split widget callback wrapping logic out from hook callback wrapping.
|
Ready for review! |
|
Will Review Hi @westonruter, |
kienstra
reviewed
Mar 11, 2018
| * After a test method runs, reset any state in WordPress the test method might have changed. | ||
| */ | ||
| public function tearDown() { | ||
| $GLOBALS['wp_registered_widgets'] = $this->original_wp_registered_widgets; // WPCS: override ok. |
There was a problem hiding this comment.
Good idea to reset the original global $wp_registered_widgets.
There was a problem hiding this comment.
It should be something that gets reset for us automatically, but it wasn't so this is to ensure we reset the global state.
kienstra
reviewed
Mar 12, 2018
| return sprintf( | ||
| '<!--%samp-source-stack %s-->', | ||
| $is_start ? '' : '/', | ||
| str_replace( '--', '', wp_json_encode( $source ) ) |
There was a problem hiding this comment.
It's nice how this adds the json-encoded source data to the comment.
kienstra
approved these changes
Mar 12, 2018
There was a problem hiding this comment.
Approved
Hi @westonruter,
It's nice how this displays the function in the UI, and places the json-encoded sources in the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example validation data for when a Custom HTML widget is added which includes a
scripttag:Fixes #1005.