Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces around commas in value property lists #1112

Merged
merged 1 commit into from
May 3, 2018

Conversation

westonruter
Copy link
Member

This prevents the following from being erroneously reported as a validation error:

<meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">

The spaces between values are perfectly fine.

@westonruter westonruter added this to the v1.0 milestone May 3, 2018
@westonruter westonruter requested a review from kienstra May 3, 2018 19:26
Copy link
Contributor

@kienstra kienstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Hi @westonruter,
This looks good, and it fixed the issue locally.

I also saw the invalid_element error in the validator, when using your <meta> snippet above in header.php.

Removed:
><head …>  <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">…

With this PR applied, that error doesn't appear.

@westonruter westonruter merged commit 8f0c5ca into develop May 3, 2018
@westonruter westonruter deleted the fix/meta-viewport-value-spaces branch July 5, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants