Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testimonial 1 #8

Closed
iamtakashi opened this issue Feb 26, 2020 · 1 comment
Closed

Testimonial 1 #8

iamtakashi opened this issue Feb 26, 2020 · 1 comment

Comments

@iamtakashi
Copy link
Contributor

iamtakashi commented Feb 26, 2020

Mockup
testimonial-1

<!-- wp:columns {"align":"wide"} -->
<div class="wp-block-columns alignwide"><!-- wp:column {"width":50} -->
<div class="wp-block-column" style="flex-basis:50%"><!-- wp:heading -->
<h2><strong>Testimonial</strong></h2>
<!-- /wp:heading -->

<!-- wp:spacer {"height":401} -->
<div style="height:401px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:quote -->
<blockquote class="wp-block-quote"><p><em>Great top, got the camel. So fresh and with a different take with white stripe on sleeves. Comfy fit, quite loose so could go a size down but like it loose fit!</em></p><cite>Name</cite></blockquote>
<!-- /wp:quote --></div>
<!-- /wp:column -->

<!-- wp:column {"width":50} -->
<div class="wp-block-column" style="flex-basis:50%"><!-- wp:image {"id":9631,"sizeSlug":"full"} -->
<figure class="wp-block-image size-full"><img src="https://iamtakashi.files.wordpress.com/2020/02/dmitriy-ilkevich-zg3alxw9fb0-unsplash-2.jpg" alt="" class="wp-image-9631"/></figure>
<!-- /wp:image --></div>
<!-- /wp:column --></div>
<!-- /wp:columns -->

Front-end
screencapture-iamtakashi-wordpress-testimonial-1-2020-02-27-10_26_18

Note
There are a number of ways to build this such as using Media & Text, but Image block could use a block style to add the decorative background.

We need a font-size option for Heading.

I've used a spacer to give a space between the heading and the quote, but the height of the spacer will be depending on the height of the image.

The quote block also could use a better block style as well. It'd be nice if the font for the citation is different from the quote to give a bit of contrast.

@alaczek
Copy link
Contributor

alaczek commented Mar 3, 2020

Headings font size was brought up in this issue, and the consensus was it doesn't make sense to add those controls, because it would upset the type scale. I can see that point, but I myself often find I'd like to tweak heading size, and since we can't resort to using paragraphs more often, which isn't great for SEO.

Ideally we'll have some control over heading size via global styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants