Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect dockerignore #8

Open
samouri opened this issue Feb 9, 2018 · 1 comment
Open

respect dockerignore #8

samouri opened this issue Feb 9, 2018 · 1 comment

Comments

@samouri
Copy link
Contributor

samouri commented Feb 9, 2018

As @sirreal discovered, .dockerignore files are currently ignored by the tar stream process in the builder. We should respect .dockerignore files when building the build context
@sirreal
Copy link
Member

sirreal commented Feb 9, 2018 •
edited
Loading

As you noted, this is likely related to the way Docker engine receives a tar archive and Docker build from a tar uses it as the context, it doesn't create a context from the tar. This effectively circumvents the .dockerignore.

At least that's the best guess 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sirreal @samouri