From 9d4cc184bc2a1c1c52da8b61aa0cac0f6eceb67b Mon Sep 17 00:00:00 2001 From: anomiex Date: Mon, 18 Nov 2024 16:55:49 +0000 Subject: [PATCH] Clean up some workarounds for old upstream bugs (#40199) * We no longer need to care about nanoid v3 thinking "browser === esm", because the GB package that had that dep no longer does. * Various `jsx-a11y/label-has-associated-control` ignores referring to jsx-eslint/eslint-plugin-jsx-a11y#869 seem to be fixed now that #39736 requires we use `htmlFor`. The one place still needing an ignore is jsx-eslint/eslint-plugin-jsx-a11y#578 instead. * Remove reference to deleted renovate issue. * Move reference to a Storybook bug to the code actually implementing the workaround. * Update Storybook FAQ reference. * Remove TODO references to a fixed Storybook bug (and fix a wrong prop in one story). * Remove workaround for WordPress/WordPress-Coding-Standards#2390. Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/11896972496 Upstream-Ref: Automattic/jetpack@62e385bd0e83cbfda590fbc70927636109205e1c --- src/contact-form/class-admin.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/contact-form/class-admin.php b/src/contact-form/class-admin.php index d7ba738..0500a0c 100644 --- a/src/contact-form/class-admin.php +++ b/src/contact-form/class-admin.php @@ -1428,8 +1428,7 @@ public function grunion_recheck_queue() { $query = 'post_type=feedback&post_status=publish'; if ( isset( $_POST['limit'] ) && isset( $_POST['offset'] ) ) { - // phpcs:ignore Generic.Strings.UnnecessaryStringConcat.Found -- Avoiding https://github.com/WordPress/WordPress-Coding-Standards/issues/2390 - $query .= '&posts_per' . '_page=' . (int) $_POST['limit'] . '&offset=' . (int) $_POST['offset']; + $query .= '&posts_per_page=' . (int) $_POST['limit'] . '&offset=' . (int) $_POST['offset']; } $approved_feedbacks = get_posts( $query );