Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordAds: Add block tests and fixtures #19129

Merged
merged 1 commit into from
Mar 12, 2021
Merged

WordAds: Add block tests and fixtures #19129

merged 1 commit into from
Mar 12, 2021

Conversation

aaronrobertshaw
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw commented Mar 11, 2021 •
edited
Loading

Changes proposed in this Pull Request:

  • Refactors WordAds block to functional component and extracts controls
  • Adds fixtures and block tests for the WordAds block

Does this pull request change what data or activity we track or use?

No change.

Testing instructions:

  1. Checkout this PR branch
  2. Run the WordAds block tests cd projects/plugins/jetpack && yarn jest extensions/blocks/wordads/test/
  3. Test the block still functions correctly in the post editor

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] WordAds [Status] Needs Team Review [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Mar 11, 2021
@aaronrobertshaw aaronrobertshaw requested a review from a team March 11, 2021 09:00
@aaronrobertshaw aaronrobertshaw self-assigned this Mar 11, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello aaronrobertshaw! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D58522-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined

jetpack plugin:

  • Next scheduled release: April 6, 2021.
  • Scheduled code freeze: March 29, 2021

@aaronrobertshaw aaronrobertshaw changed the title Wordads: Add block tests and fixtures WordAds: Add block tests and fixtures Mar 11, 2021
@jeherve jeherve added this to the 9.6 milestone Mar 11, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels Mar 11, 2021
jeherve
jeherve approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. 🚢

@aaronrobertshaw aaronrobertshaw merged commit 70a8661 into master Mar 12, 2021
@aaronrobertshaw aaronrobertshaw deleted the add/wordads-tests-and-fixtures branch March 12, 2021 01:09
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 12, 2021
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D58522-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@aaronrobertshaw
Copy link
Contributor Author

Needed to rebase diff. Build is failing at present. Will revisit committing the diff Monday.

This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
@aaronrobertshaw
Copy link
Contributor Author

Deployed: rWP222712

This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Block] Ad [Feature] WordAds [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
jetpack/9.6
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrobertshaw @matticbot @jeherve