Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions: use new plugin template registration API for subscription templates #39853

Open
Tracked by #39818
simison opened this issue Oct 21, 2024 · 1 comment
Open
Tracked by #39818
Assignees
Labels
[Block] Subscriptions [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@simison
Copy link
Member

simison commented Oct 21, 2024

In Jetpack Newsletters, we use a bit complicated way (as there wasn't an API before) to register templates that people can use to modify subscription popups, overlays and such. Basically each of these "preview and edit" links opens a pre-defined template:

Image

There's now a new official API we can migrate to:

This will ensure better compatibility and stability of the functionality going forward, as well better example within the codebase for others at a8c and the community how to do something like this.

We'll need to make sure that previously saved modifications are carried over to new system.

@simison simison added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Block] Subscriptions labels Oct 21, 2024
@simison simison closed this as completed Oct 21, 2024
@simison simison closed this as completed Oct 21, 2024
@simison simison reopened this Oct 21, 2024
@jeherve
Copy link
Member

jeherve commented Oct 28, 2024

Ah, I had just created #39923 after seeing the dev note. I'll close my issue as duplicate. :)

@jeherve jeherve changed the title Use new plugin template registration API for subscription templates Subscriptions: use new plugin template registration API for subscription templates Oct 28, 2024
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

3 participants